[test-failed]: Chrome UI Functional Tests1.test/functional/apps/discover/_filter_editor·ts - discover app discover filter editor filter editor version fields should support range filter on version fields #129847

DianaDerevyankina · 2022-04-08T12:37:17Z

Summary

Add "kibana_admin", "version_test" and "test_logstash_reader" role permissions to test user.

For maintainers

This was checked for breaking API changes and was labeled appropriately

…ver/_filter_editor·ts - discover app discover filter editor filter editor version fields should support range filter on version fields

kertal · 2022-04-11T11:40:23Z

test/functional/apps/discover/_filter_editor.ts

@@ -16,7 +16,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
  const esArchiver = getService('esArchiver');
  const kibanaServer = getService('kibanaServer');
  const filterBar = getService('filterBar');
-  const PageObjects = getPageObjects(['common', 'discover', 'timePicker']);


I think this could be e a typical cloud testing error, maybe insufficient permission:
#126377 adding version_test
But it doesn't seem to be used like context_encoded_param here

kibana/test/functional/apps/discover/_context_encoded_url_param.ts

Line 22 in 5533748

await security.testUser.setRoles(['kibana_admin', 'context_encoded_param']);

await security.testUser.setRoles(['kibana_admin', 'version_test']);

test/functional/apps/discover/_filter_editor.ts

liza-mae

Update set roles to include test_logstash_reader for it to run on cloud.

kertal

LGTM, thx a lot for taking care of this 👍

elasticmachine · 2022-04-20T10:25:57Z

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

kertal

LGTM 👍 , approving again, since my former approval was not enough

liza-mae

LGTM, thanks!

DianaDerevyankina · 2022-04-22T08:35:46Z

@elasticmachine merge upstream

kibana-ci · 2022-04-22T09:50:07Z

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

💚 Build #39368 succeeded 3142237
💚 Build #38644 succeeded 1c50563
💚 Build #37261 succeeded 1afd329
💚 Build #37078 succeeded b527659

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @dziyanadzeraviankina

…ver/_filter_editor·ts - discover app discover filter editor filter editor version fields should support range filter on version fields (#129847) * [test-failed]: Chrome UI Functional Tests1.test/functional/apps/discover/_filter_editor·ts - discover app discover filter editor filter editor version fields should support range filter on version fields * Set "version_test" permissions to kibana_admin role * Add after block to reset permission * Add "test_logstash_reader" role Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 706d926)

kibanamachine · 2022-04-22T11:12:53Z

💚 All backports created successfully

Status	Branch	Result
✅	8.2
✅	8.1

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

…ver/_filter_editor·ts - discover app discover filter editor filter editor version fields should support range filter on version fields (#129847) (#130847) * [test-failed]: Chrome UI Functional Tests1.test/functional/apps/discover/_filter_editor·ts - discover app discover filter editor filter editor version fields should support range filter on version fields * Set "version_test" permissions to kibana_admin role * Add after block to reset permission * Add "test_logstash_reader" role Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 706d926) Co-authored-by: Diana Derevyankina <54894989+DziyanaDzeraviankina@users.noreply.github.com>

…ver/_filter_editor·ts - discover app discover filter editor filter editor version fields should support range filter on version fields (#129847) (#130848) * [test-failed]: Chrome UI Functional Tests1.test/functional/apps/discover/_filter_editor·ts - discover app discover filter editor filter editor version fields should support range filter on version fields * Set "version_test" permissions to kibana_admin role * Add after block to reset permission * Add "test_logstash_reader" role Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 706d926) Co-authored-by: Diana Derevyankina <54894989+DziyanaDzeraviankina@users.noreply.github.com>

…ver/_filter_editor·ts - discover app discover filter editor filter editor version fields should support range filter on version fields (elastic#129847) * [test-failed]: Chrome UI Functional Tests1.test/functional/apps/discover/_filter_editor·ts - discover app discover filter editor filter editor version fields should support range filter on version fields * Set "version_test" permissions to kibana_admin role * Add after block to reset permission * Add "test_logstash_reader" role Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

[test-failed]: Chrome UI Functional Tests1.test/functional/apps/disco…

b527659

…ver/_filter_editor·ts - discover app discover filter editor filter editor version fields should support range filter on version fields

DianaDerevyankina self-assigned this Apr 8, 2022

kertal reviewed Apr 11, 2022

View reviewed changes

DianaDerevyankina added 3 commits April 11, 2022 15:58

Set "version_test" permissions to kibana_admin role

21770a4

Add after block to reset permission

1afd329

Merge branch 'main' into issues/128103

1c50563

DianaDerevyankina added Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. v8.2.0 v8.1.1 v8.1.2 v8.1.3 release_note:skip Skip the PR/issue when compiling release notes labels Apr 19, 2022

DianaDerevyankina requested review from VladLasitsa and alexwizp April 19, 2022 09:17

liza-mae self-requested a review April 19, 2022 18:10

liza-mae reviewed Apr 19, 2022

View reviewed changes

test/functional/apps/discover/_filter_editor.ts Outdated Show resolved Hide resolved

liza-mae suggested changes Apr 19, 2022

View reviewed changes

DianaDerevyankina added 2 commits April 20, 2022 12:40

Merge branch 'main' into issues/128103

f6ea1ec

Add "test_logstash_reader" role

3142237

kertal requested review from kertal and liza-mae April 20, 2022 10:25

kertal approved these changes Apr 20, 2022

View reviewed changes

kertal marked this pull request as ready for review April 20, 2022 10:25

kertal requested a review from a team as a code owner April 20, 2022 10:25

kertal approved these changes Apr 20, 2022

View reviewed changes

liza-mae approved these changes Apr 21, 2022

View reviewed changes

Merge branch 'main' into issues/128103

08f6cf4

DianaDerevyankina added auto-backport Deprecated - use backport:version if exact versions are needed v8.3.0 labels Apr 22, 2022

DianaDerevyankina merged commit 706d926 into elastic:main Apr 22, 2022

kibanamachine mentioned this pull request Apr 22, 2022

[8.2] [test-failed]: Chrome UI Functional Tests1.test/functional/apps/discover/_filter_editor·ts - discover app discover filter editor filter editor version fields should support range filter on version fields (#129847) #130847

Merged

kibanamachine mentioned this pull request Apr 22, 2022

[8.1] [test-failed]: Chrome UI Functional Tests1.test/functional/apps/discover/_filter_editor·ts - discover app discover filter editor filter editor version fields should support range filter on version fields (#129847) #130848

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[test-failed]: Chrome UI Functional Tests1.test/functional/apps/discover/_filter_editor·ts - discover app discover filter editor filter editor version fields should support range filter on version fields #129847

[test-failed]: Chrome UI Functional Tests1.test/functional/apps/discover/_filter_editor·ts - discover app discover filter editor filter editor version fields should support range filter on version fields #129847

DianaDerevyankina commented Apr 8, 2022 •

edited

Loading

kertal Apr 11, 2022

liza-mae left a comment

kertal left a comment

elasticmachine commented Apr 20, 2022

kertal left a comment

liza-mae left a comment

DianaDerevyankina commented Apr 22, 2022

kibana-ci commented Apr 22, 2022

kibanamachine commented Apr 22, 2022

[test-failed]: Chrome UI Functional Tests1.test/functional/apps/discover/_filter_editor·ts - discover app discover filter editor filter editor version fields should support range filter on version fields #129847

[test-failed]: Chrome UI Functional Tests1.test/functional/apps/discover/_filter_editor·ts - discover app discover filter editor filter editor version fields should support range filter on version fields #129847

Conversation

DianaDerevyankina commented Apr 8, 2022 • edited Loading

Summary

For maintainers

kertal Apr 11, 2022

Choose a reason for hiding this comment

liza-mae left a comment

Choose a reason for hiding this comment

kertal left a comment

Choose a reason for hiding this comment

elasticmachine commented Apr 20, 2022

kertal left a comment

Choose a reason for hiding this comment

liza-mae left a comment

Choose a reason for hiding this comment

DianaDerevyankina commented Apr 22, 2022

kibana-ci commented Apr 22, 2022

💚 Build Succeeded

Metrics [docs]

History

kibanamachine commented Apr 22, 2022

💚 All backports created successfully

Questions ?

DianaDerevyankina commented Apr 8, 2022 •

edited

Loading