Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrating Dashboard TimePicker Tests To Use CCS #130286

Merged
merged 13 commits into from
May 18, 2022
Merged

Migrating Dashboard TimePicker Tests To Use CCS #130286

merged 13 commits into from
May 18, 2022

Conversation

cuff-links
Copy link
Contributor

Part of #126392

@cuff-links cuff-links requested a review from a team as a code owner April 14, 2022 15:50
@cuff-links cuff-links added v8.3.0 v8.2.0 v8.1.2 release_note:skip Skip the PR/issue when compiling release notes v8.2.1 Team:QA Team label for QA Team and removed v8.2.0 labels Apr 14, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-qa (Team:QA)

@cuff-links cuff-links added test_ui_functional Feature:Functional Testing auto-backport Deprecated - use backport:version if exact versions are needed labels Apr 14, 2022
ThomThomson
ThomThomson approved these changes Apr 14, 2022
View reviewed changes
Copy link
Contributor

@ThomThomson ThomThomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Presentation team changes LGTM assuming that the CI passes!

Nice solution for switching which archiver to use.

@cuff-links cuff-links mentioned this pull request Apr 15, 2022
Closed
@cuff-links cuff-links marked this pull request as draft April 15, 2022 15:39
John Dorlus and others added 9 commits April 15, 2022 23:11
Added conditional for data.
b239545
Merge branch 'main' of github.com:elastic/kibana into Migrate_Dashboa…
8766997 
…rd_Time_Picker_Tests_To_Use_CCS
@kibanamachine
[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…
624f76f 
…-fix'
Merge branch 'main' of github.com:elastic/kibana into Migrate_Dashboa…
882bc89 
…rd_Time_Picker_Tests_To_Use_CCS
Merge branch 'main' of github.com:elastic/kibana into Migrate_Dashboa…
784cb15 
…rd_Time_Picker_Tests_To_Use_CCS
Fixed CCS dashboard test.
05f6760
Merge branch 'Migrate_Dashboard_Time_Picker_Tests_To_Use_CCS' of gith…
8f51b3f 
…ub.com:cuff-links/kibana into Migrate_Dashboard_Time_Picker_Tests_To_Use_CCS
Merge branch 'main' of github.com:elastic/kibana into Migrate_Dashboa…
e8a5309 
…rd_Time_Picker_Tests_To_Use_CCS
Removed file that should have been removed via merge.
85e240b
@kibana-ci
Copy link
Collaborator

kibana-ci commented May 18, 2022 •
edited
Loading

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cuff-links cuff-links marked this pull request as ready for review May 18, 2022 01:04
@cuff-links
Copy link
Contributor Author

jenkins test this

@cuff-links cuff-links merged commit 605020d into elastic:main May 18, 2022
@cuff-links cuff-links removed auto-backport Deprecated - use backport:version if exact versions are needed v8.1.2 v8.2.1 labels May 18, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label May 18, 2022
@cuff-links cuff-links mentioned this pull request May 18, 2022
Closed
32 tasks
@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
❌ 8.1 Backport failed because of merge conflicts
❌ 8.2 Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 130286

Questions ?

Please refer to the Backport tool documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThomThomson ThomThomson ThomThomson approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting Feature:Functional Testing release_note:skip Skip the PR/issue when compiling release notes Team:QA Team label for QA Team test_ui_functional v8.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cuff-links @elasticmachine @kibana-ci @kibanamachine @ThomThomson