[Discover][Alerting] Implement editing of data view, query, filters #130462

dimaanj · 2022-04-18T15:05:56Z

Summary

DataView

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)
If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)
This was checked for cross-browser compatibility

…-data-view-query-filters

x-pack/plugins/stack_alerts/public/alert_types/components/query_popover.tsx

x-pack/plugins/stack_alerts/public/alert_types/components/data_view_select_popover.tsx

kertal

Just a quick first feedback, I think for filters we might need to place an UI element like a plus button to add new filters because the current way this is done leads to confusion:
So clicking on Filters wouldn't trigger adding a new one, there would be a dedicated UI element for that

ryankeairns · 2022-04-20T21:40:23Z

...ck/plugins/stack_alerts/public/alert_types/es_query/expression/search_source_expression.scss

@@ -1,3 +1,7 @@
+html {
+  overflow: hidden;


Instead, is it possible to set the suggestionSize on the component to s?

I see a prop here:

kibana/src/plugins/unified_search/public/typeahead/suggestions_component.tsx

Line 160 in 3b37b27

suggestionsSize?: SuggestionsListSize;

I am not sure where/how to pass in this prop, so (as a very quick-and-dirty test) I hardcoded this value to s and get this result which I suspect addresses the original issue:

Yes, it's possible, already applied.

dimaanj · 2022-04-25T07:34:13Z

src/plugins/unified_search/public/search_bar/search_bar.tsx

@@ -364,7 +364,7 @@ class SearchBarUI extends Component<SearchBarProps, State> {
          isLoading={this.props.isLoading}
          fillSubmitButton={this.props.fillSubmitButton || false}
          prepend={
-            this.props.showFilterBar && this.state.query


This was removed to be able to show saved query management, without filter bar. Filter bar added manually, omitting some features. Would it be safe change?

kertal

For me using the old layout would work, question is if we need to adapt the layout here @andreadelrio ?

One thing to also keep in mind, we might soon be able to use the unified search bar here:
#128401

one think that didn't work, I got an endless spinner when trying to edit the alert rule in Stack management

ryankeairns · 2022-04-25T13:19:26Z

I may be getting ahead as this PR is in draft, but I'll point these out as I noticed them while testing the flyout:

Should we prompt to close/save the flyout when they click back in the main KQL bar
Otherwise, you see this overlapping of elements:

The previous search string is quite sticky
If I remove it from the main page search bar, it still remains in the flyout even after close/re-open/refresh.

kertal · 2022-05-02T07:52:24Z

@elasticmachine merge upstream

kibana-ci · 2022-05-02T08:25:09Z

💔 Build Failed

Failed CI Steps

Test Failures

[job] [logs] Default CI Group #6 / Discover alerting Search source Alert should display warning about updated alert rule
[job] [logs] Default CI Group #6 / Discover alerting Search source Alert should display warning about updated alert rule
[job] [logs] Jest Tests #5 / SearchSourceAlertTypeExpression should render error prompt
[job] [logs] Jest Tests #5 / SearchSourceAlertTypeExpression should render loading prompt
[job] [logs] Jest Tests #5 / SearchSourceAlertTypeExpression should render SearchSourceAlertTypeExpression with expected components

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`stackAlerts`	125	128	+3
`unifiedSearch`	157	158	+1
total			+4

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`unifiedSearch`	75	77	+2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`discover`	407.9KB	408.0KB	+117.0B
`stackAlerts`	202.8KB	206.2KB	+3.4KB
`unifiedSearch`	116.2KB	117.8KB	+1.5KB
total			+5.0KB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id	before	after	diff
`unifiedSearch`	11	12	+1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`discover`	40.3KB	40.3KB	+30.0B
`stackAlerts`	12.6KB	13.0KB	+468.0B
`unifiedSearch`	87.8KB	88.0KB	+246.0B
total			+744.0B

Unknown metric groups

API count

id	before	after	diff
`unifiedSearch`	79	81	+2

async chunk count

id	before	after	diff
`unifiedSearch`	9	10	+1

ESLint disabled line counts

id	before	after	diff
`unifiedSearch`	15	16	+1

References to deprecated APIs

id	before	after	diff
`stackAlerts`	24	39	+15

Total ESLint disabled count

id	before	after	diff
`unifiedSearch`	15	16	+1

History

💔 Build #40093 failed 754fdde
💔 Build #40072 failed 4f68aac
💔 Build #39379 failed 485b209
💔 Build #39124 failed 48bb6f6

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @dmitriynj

kertal · 2022-05-05T08:11:47Z

Should we prompt to close/save the flyout when they click back in the main KQL bar
Otherwise, you see this overlapping of elements:

@ryankeairns
I think what we could do is, using the flyout to own focus and getting closed when clicked outside

However, AFAIK we don't have currently access to the way it's being rendered, so it would need to be solved in a separate PR ... or being a feature request for our alerting efforts

The previous search string is quite sticky If I remove it from the main page search bar, it still remains in the flyout even after close/re-open/refresh.

Ok, if this is still the case this should be solved. every time the flyout is opened it should be reset to the current state of our search.

dimaanj · 2022-05-06T07:37:55Z

Closing current PR, since #131688 created.

[Discover] add initial setup

d70287a

dimaanj added Feature:Discover Discover Application release_note:feature Makes this part of the condensed release notes Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. v8.3.0 labels Apr 18, 2022

dimaanj self-assigned this Apr 18, 2022

dimaanj added 4 commits April 19, 2022 20:05

[Discover] add filters edit

e02187d

[Discover] clean up imports, add comment

48bb6f6

Merge branch 'main' of https://github.com/elastic/kibana into editing…

301a531

…-data-view-query-filters

[Discover] add query edit option

485b209

ryankeairns reviewed Apr 20, 2022

View reviewed changes

x-pack/plugins/stack_alerts/public/alert_types/components/query_popover.tsx Outdated Show resolved Hide resolved

ryankeairns reviewed Apr 20, 2022

View reviewed changes

x-pack/plugins/stack_alerts/public/alert_types/components/data_view_select_popover.tsx Show resolved Hide resolved

kertal reviewed Apr 20, 2022

View reviewed changes

ryankeairns reviewed Apr 20, 2022

View reviewed changes

dimaanj added 2 commits April 25, 2022 10:26

[Discover] change flyout, add saved query functionality

4f68aac

[Discover] improve saved query usage

5beaab5

dimaanj commented Apr 25, 2022

View reviewed changes

dimaanj added 2 commits April 25, 2022 12:57

[Discover] add suggestions size

dc0a760

[Discover] add type import

754fdde

kertal reviewed Apr 25, 2022

View reviewed changes

Merge branch 'main' into editing-data-view-query-filters

064a030

dimaanj closed this May 6, 2022

dimaanj mentioned this pull request May 6, 2022

[Discover][Alerting] Implement editing of dataView, query & filters #131688

Merged

6 tasks

ryankeairns mentioned this pull request May 6, 2022

[Discover][Alerting] Prevent search suggestions and rule flyout from being open simultaneously #131721

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Discover][Alerting] Implement editing of data view, query, filters #130462

[Discover][Alerting] Implement editing of data view, query, filters #130462

dimaanj commented Apr 18, 2022 •

edited

Loading

kertal left a comment

ryankeairns Apr 20, 2022

dimaanj Apr 25, 2022

dimaanj Apr 25, 2022

kertal left a comment

ryankeairns commented Apr 25, 2022

kertal commented May 2, 2022

kibana-ci commented May 2, 2022 •

edited

Loading

API count

async chunk count

ESLint disabled line counts

References to deprecated APIs

Total ESLint disabled count

kertal commented May 5, 2022

dimaanj commented May 6, 2022

[Discover][Alerting] Implement editing of data view, query, filters #130462

[Discover][Alerting] Implement editing of data view, query, filters #130462

Conversation

dimaanj commented Apr 18, 2022 • edited Loading

Summary

kertal left a comment

Choose a reason for hiding this comment

ryankeairns Apr 20, 2022

Choose a reason for hiding this comment

dimaanj Apr 25, 2022

Choose a reason for hiding this comment

dimaanj Apr 25, 2022

Choose a reason for hiding this comment

kertal left a comment

Choose a reason for hiding this comment

ryankeairns commented Apr 25, 2022

kertal commented May 2, 2022

kibana-ci commented May 2, 2022 • edited Loading

💔 Build Failed

Failed CI Steps

Test Failures

Metrics [docs]

Module Count

Public APIs missing comments

Async chunks

Public APIs missing exports

Page load bundle

API count

async chunk count

ESLint disabled line counts

References to deprecated APIs

Total ESLint disabled count

History

kertal commented May 5, 2022

dimaanj commented May 6, 2022

dimaanj commented Apr 18, 2022 •

edited

Loading

kibana-ci commented May 2, 2022 •

edited

Loading