Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Unified search] Support fields custom label on filter editor #130533

Merged
merged 9 commits into from
May 3, 2022
Merged

[Unified search] Support fields custom label on filter editor #130533

merged 9 commits into from
May 3, 2022

Conversation

stratoula
Copy link
Contributor

@stratoula stratoula commented Apr 19, 2022 •
edited
Loading

Summary

Closes #128101

Displays field custom labels on the Filter editor. Also the filter badges and the filter application modal are also using the custom label.

image

image

image

image

@stratoula stratoula changed the title [Unified search] Support fields custom label [Unified search] Support fields custom label on filter editor Apr 19, 2022
@stratoula stratoula added release_note:enhancement backport:skip This commit does not require backporting Feature:Unified search Unified search related tasks v8.3.0 labels Apr 20, 2022
@stratoula stratoula marked this pull request as ready for review April 20, 2022 09:13
@stratoula stratoula requested a review from a team as a code owner April 20, 2022 09:13
@stratoula stratoula requested a review from a team April 20, 2022 09:46
@stratoula
Copy link
Contributor Author

@elastic/kibana-vis-editors I am adding you here as reviewers too (mostly for visibility) as it is related with the creation of filters from clicking on a chart.

jloleysens
jloleysens approved these changes May 2, 2022
View reviewed changes
Copy link
Contributor

@jloleysens jloleysens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @stratoula , thanks for adding tests 👏🏻 . I did not test locally, but this code LGTM.

@jloleysens
Copy link
Contributor

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
data 2851 2854 +3

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
unifiedSearch 116.2KB 116.5KB +238.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
data 416.3KB 416.5KB +234.0B
Unknown metric groups

API count

id before after diff
data 3463 3466 +3

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@stratoula stratoula merged commit 82f440b into elastic:main May 3, 2022
@KOTungseth KOTungseth mentioned this pull request May 11, 2022
Closed
kertal pushed a commit to kertal/kibana that referenced this pull request May 24, 2022
@stratoula @kibanamachine @kertal
[Unified search] Support fields custom label on filter editor (elasti…
6225fa1 
…c#130533)

* [Unified search] Support fields custom label

* Use the custom label in filter badges and popover

* Unit tests

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jloleysens jloleysens jloleysens approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting Feature:Unified search Unified search related tasks release_note:enhancement v8.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support custom label when filtering dashboard 🚀
4 participants
@stratoula @jloleysens @kibana-ci @kibanamachine