Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.2] [Controls] Clear range/time slider selections when field changes (#129824) #130827

Merged
merged 1 commit into from
Apr 21, 2022
Merged

[8.2] [Controls] Clear range/time slider selections when field changes (#129824) #130827

merged 1 commit into from
Apr 21, 2022

Conversation

Heenawter
Copy link
Contributor

Backport

This will backport the following commits from main to 8.2:

Questions ?

Please refer to the Backport tool documentation

@Heenawter Heenawter enabled auto-merge (squash) April 21, 2022 19:50
@Heenawter
[Controls] Clear range/time slider selections when field changes (ela…
e6a3789 
…stic#129824)

* Reset selections on save of existing control

* Allow reset to force render for range/time sliders

* Reset selections only when field name or data view changes

* Make generic DataControlInput interface

* Fix infinite useEffect + imports + types

* Simpler solution without resetSelections()

* Add functional tests

* Apply Devon's changes

(cherry picked from commit 5a86421)

# Conflicts:
#	src/plugins/controls/common/control_types/options_list/types.ts
@Heenawter Heenawter merged commit 0cd869c into elastic:8.2 Apr 21, 2022
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
controls 182 174 -8

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
controls 437.4KB 437.4KB -64.0B

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
controls 4 5 +1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
controls 32.3KB 32.4KB +60.0B
Unknown metric groups

API count

id before after diff
controls 188 180 -8

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Heenawter @kibana-ci