Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Infrastructure UI][Rules] Add recovery context to Log Threshold rule #131279

Conversation

simianhacker
Copy link
Member

Summary

This PR fixes #127123 by adding the available context to the Log Threshold rule.

Sample recovery context for document count without group by

{
    "conditions": "event.module equals high_cardinality",
    "group": null,
    "isRatio": false,
    "timestamp": "2022-04-29T21:22:44.721Z",
    "viewInAppUrl": "/app/logs/link-to/default/logs?time=1651267301718"
}

Sample recovery context for document count with group by

{
    "conditions": "event.module equals high_cardinality",
    "group": "group-0",
    "isRatio": false,
    "timestamp": "2022-04-29T21:19:35.701Z",
    "viewInAppUrl": "/app/logs/link-to/default/logs?time=1651266860631"
}

Sample recovery context for ratio without group by

{
    "denominatorConditions": "latency more than 0",
    "group": null,
    "isRatio": true,
    "numeratorConditions": "latency more than 200",
    "timestamp": "2022-04-29T21:27:59.753Z",
    "viewInAppUrl": "/app/logs/link-to/default/logs?time=1651267616742"
}

Sample recovery context for ratio with group by

{
    "denominatorConditions": "latency more than 0",
    "group": "group-0",
    "isRatio": true,
    "numeratorConditions": "latency more than 200",
    "timestamp": "2022-04-29T21:32:11.809Z",
    "viewInAppUrl": "/app/logs/link-to/default/logs?time=1651267742766"
}

@simianhacker simianhacker added release_note:enhancement Feature:Logs UI Logs UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.3.0 labels Apr 29, 2022
@simianhacker simianhacker marked this pull request as ready for review May 2, 2022 14:36
@simianhacker simianhacker requested a review from a team as a code owner May 2, 2022 14:36
@elasticmachine
Copy link
Contributor

Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI)

@simianhacker
Copy link
Member Author

@elasticmachine merge upstream

@Kerry350 Kerry350 self-requested a review May 12, 2022 10:43
@simianhacker simianhacker requested a review from Kerry350 May 16, 2022 16:08
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@Kerry350 Kerry350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes. LGTM 👍

@simianhacker simianhacker merged commit f296d0e into elastic:main May 17, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label May 17, 2022
@simianhacker simianhacker deleted the issue-127123-add-recovery-context-to-log-threshold-rule branch April 17, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Logs UI Logs UI feature release_note:enhancement Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v8.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Infrastructure UI][Rules] Add recovered context to the Log Threshold rule
5 participants