Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cloud Posture] add resource table columns #131484

Closed
wants to merge 2 commits into from

Conversation

orouz
Copy link
Contributor

@orouz orouz commented May 4, 2022

WIP


Summary

this PR includes:

  1. UI changes:
  • 2 new columns to the group-by-resource table: resource.type and resource.name
  • changes to the resource_id column which is shared between all 3 tables:
    • fixing the text truncation to show an elipsiss
    • sharing its definition between all three tables so it same column looks the same
  • change CIS Section to CIS Sections and render a separated array
  • added info-icon tooltip to resource_id and cluster_id
  1. API Query changes:
  • added resource.type and resource.name to the composite aggregation sources

Note

rebased on #130968

Checklist

Delete any items that are not applicable to this PR.

@orouz orouz force-pushed the findings_resource_subtype branch from 5609e9e to 2ce5672 Compare May 4, 2022 10:41
@kibana-ci
Copy link
Collaborator

kibana-ci commented May 4, 2022

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #3 / renders the table with provided items

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
cloudSecurityPosture 393.8KB 395.0KB +1.3KB

History

  • 💔 Build #42307 failed 5609e9e930fe5868c1a103c47d9588f17861ce9f

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kfirpeled
Copy link
Contributor

@orouz this can be closed?

@orouz orouz closed this May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants