Nav unified show timeline #131811

machadoum · 2022-05-09T14:27:27Z

Summary

Update useShowTimeline to read timeline status from app links config when GroupedNavigation is enabled.

It adds SecurityPageName.rulesCreateto deep links.

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support

x-pack/plugins/security_solution/public/common/utils/timeline/use_show_timeline.tsx

elasticmachine · 2022-05-11T13:51:27Z

Pinging @elastic/security-solution (Team: SecuritySolution)

elasticmachine · 2022-05-11T13:51:27Z

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

x-pack/plugins/security_solution/common/constants.ts

x-pack/plugins/security_solution/public/app/deep_links/index.ts

x-pack/plugins/security_solution/public/management/links.ts

.../plugins/security_solution/public/common/components/link_to/redirect_to_detection_engine.tsx

semd

LGTM 🚀

machadoum · 2022-05-17T11:12:54Z

...ck/plugins/security_solution/public/detections/pages/detection_engine/rules/create/index.tsx

@@ -439,7 +439,7 @@ const CreateRulePageComponent: React.FC = () => {
        </EuiFlexGroup>
      </SecuritySolutionPageWrapper>

-      <SpyRoute pageName={SecurityPageName.rules} />
+      <SpyRoute pageName={SecurityPageName.rulesCreate} />


Add rulesCreate to SpyRoute so we can disable the timeline.

Tested this locally -- LGTM 👍
And thank you for these comments, they are really helpful for code review.

machadoum · 2022-05-17T11:13:51Z

...ecurity_solution/public/detections/components/rules/pre_packaged_rules/load_empty_prompt.tsx

@@ -80,14 +67,13 @@ const PrePackagedRulesPromptComponent: React.FC<PrePackagedRulesPromptProps> = (
        <EuiFlexGroup justifyContent="center">
          <EuiFlexItem grow={false}>{loadPrebuiltRulesAndTemplatesButton}</EuiFlexItem>
          <EuiFlexItem grow={false}>
-            <LinkButton
+            <SecuritySolutionLinkButton


A small refactor.

This looks so much cleaner! 🙌 Thank you!

…-fix'

kibana-ci · 2022-05-17T13:10:57Z

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`securitySolution`	5.0MB	5.0MB	+574.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`securitySolution`	246.7KB	247.0KB	+328.0B

History

💚 Build #44946 succeeded ed17d1574876d501ff6154cb2d88d699ca26524f
💚 Build #44864 succeeded a4dac0e09db3044527df93cf654d9720969bad46
💚 Build #44823 succeeded 2ccf8c40bf78e12ba9da624b99a07a8425bf0bfb
💔 Build #44517 failed c35ca1716db1eddcd2a0460bb6504ddc1f31d19f
💔 Build #44449 failed bc2eae55b1cc63bffa7c9d83658fa160799971a1
💔 Build #44422 failed 1a33efdd4427620fd4a51bb993916781f3f2f150

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @machadoum

paul-tavares

file x-pack/plugins/security_solution/public/management/links.ts changes LGTM 👍

joeypoon

👌

banderror

Rules-related changes LGTM 👍 Tested a bit locally. Thank you @machadoum!

banderror · 2022-05-18T16:28:22Z

...ty_solution/public/detections/components/rules/pre_packaged_rules/load_empty_prompt.test.tsx

-      expect(
-        wrapper.find('[data-test-subj="load-prebuilt-rules"] button').props().disabled
-      ).toEqual(true);
+      expect(wrapper.find('button[data-test-subj="load-prebuilt-rules"]').props().disabled).toEqual(


Nit: could we just use [data-test-subj="load-prebuilt-rules"] w/o button as a selector here?

banderror · 2022-05-18T16:30:30Z

...ecurity_solution/public/detections/components/rules/pre_packaged_rules/load_empty_prompt.tsx

@@ -80,14 +67,13 @@ const PrePackagedRulesPromptComponent: React.FC<PrePackagedRulesPromptProps> = (
        <EuiFlexGroup justifyContent="center">
          <EuiFlexItem grow={false}>{loadPrebuiltRulesAndTemplatesButton}</EuiFlexItem>
          <EuiFlexItem grow={false}>
-            <LinkButton
+            <SecuritySolutionLinkButton


This looks so much cleaner! 🙌 Thank you!

banderror · 2022-05-18T16:31:46Z

...ck/plugins/security_solution/public/detections/pages/detection_engine/rules/create/index.tsx

@@ -439,7 +439,7 @@ const CreateRulePageComponent: React.FC = () => {
        </EuiFlexGroup>
      </SecuritySolutionPageWrapper>

-      <SpyRoute pageName={SecurityPageName.rules} />
+      <SpyRoute pageName={SecurityPageName.rulesCreate} />


Tested this locally -- LGTM 👍
And thank you for these comments, they are really helpful for code review.

machadoum force-pushed the nav_unified_show_timeline branch from 48076f6 to 0eed070 Compare May 11, 2022 13:43

machadoum commented May 11, 2022

View reviewed changes

x-pack/plugins/security_solution/public/common/utils/timeline/use_show_timeline.tsx Outdated Show resolved Hide resolved

machadoum marked this pull request as ready for review May 11, 2022 13:51

machadoum requested review from a team as code owners May 11, 2022 13:51

machadoum requested review from joeypoon and paul-tavares May 11, 2022 13:51

machadoum self-assigned this May 11, 2022

machadoum added release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting Security Solution Threat Hunting Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Explore labels May 11, 2022

machadoum added the v8.3.0 label May 11, 2022

machadoum requested a review from semd May 11, 2022 13:51

semd reviewed May 12, 2022

View reviewed changes

x-pack/plugins/security_solution/common/constants.ts Outdated Show resolved Hide resolved

semd reviewed May 12, 2022

View reviewed changes

x-pack/plugins/security_solution/public/app/deep_links/index.ts Outdated Show resolved Hide resolved

semd reviewed May 12, 2022

View reviewed changes

x-pack/plugins/security_solution/public/management/links.ts Outdated Show resolved Hide resolved

semd reviewed May 12, 2022

View reviewed changes

.../plugins/security_solution/public/common/components/link_to/redirect_to_detection_engine.tsx Show resolved Hide resolved

machadoum force-pushed the nav_unified_show_timeline branch 5 times, most recently from c35ca17 to 2ccf8c4 Compare May 16, 2022 09:59

machadoum requested a review from semd May 16, 2022 11:33

machadoum force-pushed the nav_unified_show_timeline branch from 2dfcde3 to a4dac0e Compare May 16, 2022 11:48

semd approved these changes May 16, 2022

View reviewed changes

machadoum added 5 commits May 17, 2022 13:01

Update useShowTimeline to work with new grouped navigation

da66631

Fix bundle size

7f5a2fe

Fix broken unit tests

7a0355b

Please code review

d5a2d89

Fix create rules deepLink

679ac04

machadoum force-pushed the nav_unified_show_timeline branch from ed17d15 to 679ac04 Compare May 17, 2022 11:07

machadoum commented May 17, 2022

View reviewed changes

[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…

c70fae9

…-fix'

paul-tavares approved these changes May 17, 2022

View reviewed changes

semd mentioned this pull request May 17, 2022

[Security Solution] MVP for the new Security side navigation #130023

Closed

joeypoon approved these changes May 17, 2022

View reviewed changes

machadoum enabled auto-merge (squash) May 18, 2022 07:34

banderror approved these changes May 18, 2022

View reviewed changes

machadoum merged commit fa7df79 into elastic:main May 18, 2022

kibanamachine added the backport:skip This commit does not require backporting label May 18, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Nav unified show timeline #131811

Nav unified show timeline #131811

machadoum commented May 9, 2022 •

edited

Loading

elasticmachine commented May 11, 2022

elasticmachine commented May 11, 2022

semd left a comment

machadoum May 17, 2022

banderror May 18, 2022

machadoum May 17, 2022

banderror May 18, 2022

kibana-ci commented May 17, 2022

paul-tavares left a comment

joeypoon left a comment

banderror left a comment

banderror May 18, 2022

banderror May 18, 2022

banderror May 18, 2022

Nav unified show timeline #131811

Nav unified show timeline #131811

Conversation

machadoum commented May 9, 2022 • edited Loading

Summary

Checklist

elasticmachine commented May 11, 2022

elasticmachine commented May 11, 2022

semd left a comment

Choose a reason for hiding this comment

machadoum May 17, 2022

Choose a reason for hiding this comment

banderror May 18, 2022

Choose a reason for hiding this comment

machadoum May 17, 2022

Choose a reason for hiding this comment

banderror May 18, 2022

Choose a reason for hiding this comment

kibana-ci commented May 17, 2022

💚 Build Succeeded

Metrics [docs]

Async chunks

Page load bundle

History

paul-tavares left a comment

Choose a reason for hiding this comment

joeypoon left a comment

Choose a reason for hiding this comment

banderror left a comment

Choose a reason for hiding this comment

banderror May 18, 2022

Choose a reason for hiding this comment

banderror May 18, 2022

Choose a reason for hiding this comment

banderror May 18, 2022

Choose a reason for hiding this comment

machadoum commented May 9, 2022 •

edited

Loading