Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lens] Unskip test #132009

Merged
merged 3 commits into from
May 12, 2022
Merged

[Lens] Unskip test #132009

merged 3 commits into from
May 12, 2022

Conversation

flash1293
Copy link
Contributor

Fixes #108352

The test itself should be fine, I think this has been failing due to elastic/elasticsearch#86614
Once the ES snapshot is updated in Kibana, I'm going to run a flaky runner on this.

@flash1293 flash1293 added Team:Visualizations Visualization editors, elastic-charts and infrastructure release_note:skip Skip the PR/issue when compiling release notes Feature:Lens auto-backport Deprecated - use backport:version if exact versions are needed v8.3.0 v7.17.4 labels May 11, 2022
@spalger
Copy link
Contributor

spalger commented May 11, 2022

I think we can merge this now, but if you want to wait I understand

@flash1293
Copy link
Contributor Author

@spalger I will kick off a flaky runner to be sure

@spalger
Copy link
Contributor

spalger commented May 11, 2022

@flash1293 It will likely fail in the flaky test runner, but the new snapshot is going to be here in a matter of hours and I'm confident that will fix this. I'd prefer we wait for the flaky test runner until the new snapshot is in.

@flash1293
Copy link
Contributor Author

@elasticmachine merge upstream

@flash1293
Copy link
Contributor Author

Flaky runner here: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/604

@flash1293
Copy link
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@flash1293 flash1293 marked this pull request as ready for review May 11, 2022 18:16
@flash1293 flash1293 requested a review from a team as a code owner May 11, 2022 18:16
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

stratoula
stratoula approved these changes May 12, 2022
View reviewed changes
Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! LGTM! Code review only

@flash1293 flash1293 merged commit 6af6863 into elastic:main May 12, 2022
@kibanamachine kibanamachine mentioned this pull request May 12, 2022
Merged
kibanamachine pushed a commit that referenced this pull request May 12, 2022
@flash1293
unskip test (#132009)
ad098cf 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 6af6863)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 7.17

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request May 12, 2022
@kibanamachine @flash1293
unskip test (#132009) (#132130)
e4876f3 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 6af6863)

Co-authored-by: Joe Reuter <johannes.reuter@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stratoula stratoula stratoula approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Lens release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.17.4 v8.3.0
Projects
None yet
Milestone
No milestone
6 participants
@flash1293 @spalger @kibana-ci @elasticmachine @kibanamachine @stratoula