Update navigation landing pages to use appLinks config #132027

machadoum · 2022-05-11T13:03:21Z

Summary

Update navigation landing pages to use appLinks config.
It also adds description and image to the Detection Response app link.

Wait for design to provide a better screenshot for Detection Response
Wait for final page descriptions

User mock

Manage mock

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support

x-pack/plugins/security_solution/public/app/translations.ts

elasticmachine · 2022-05-11T13:21:11Z

Pinging @elastic/security-solution (Team: SecuritySolution)

elasticmachine · 2022-05-11T13:21:11Z

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

x-pack/plugins/security_solution/public/hosts/links.ts

x-pack/plugins/security_solution/public/management/links.ts

x-pack/plugins/security_solution/public/users/links.ts

x-pack/plugins/security_solution/public/common/hooks/use_experimental_features.ts

x-pack/plugins/security_solution/public/landing_pages/pages/manage.tsx

semd

LGTM! 🚀 only that NIT about the hook encapsulation.
Thanks Pablo!

x-pack/plugins/security_solution/public/landing_pages/components/landing_links_images.tsx

x-pack/plugins/security_solution/public/users/links.ts

machadoum · 2022-05-16T15:05:08Z

I am assuming this placeholder text is yet to be updated.

~~Yes, @ashokaditya. I am still waiting for the design team to provide ~~three~~ two remaining descriptions.~~

dasansol92

Hey, this looks great! Left some more questions, let me know if anything is not clear at all 🙂 Thanks for doing all these changes! 🔥

x-pack/plugins/security_solution/public/common/links/links.test.ts

x-pack/plugins/security_solution/public/management/links.ts

dasansol92 · 2022-05-17T07:41:00Z

x-pack/plugins/security_solution/public/landing_pages/constants.ts

+  itemIds: SecurityPageName[];
+}
+
+export const MANAGE_NAVIGATION_CATEGORIES: LandingNavGroup[] = [


Is this used somewhere? Does it means rules and expections will be under Management section?

Are the itemIds array sorted? If they are, itemIds for Endpoints should be like this I guess:

[ SecurityPageName.endpoints, SecurityPageName.policies, SecurityPageName.trustedApps, SecurityPageName.eventFilters, SecurityPageName.hostIsolationExceptions, SecurityPageName.blocklist, ]

Is this used somewhere? Does it means rules and expections will be under Management section?

It is used for the menu landing page. Yes, rules and exceptions are located on the Manage landing page.

Are the itemIds array sorted? If they are, itemIds for Endpoints should be like this I guess:

hmm, I see that on your list, hostIsolationExceptions comes before blocklist. But in the design, it is the other way around.

@bfishel Is it ok if we follow the order proposed by @dasansol92 instead the one on Figma?

Actually, it is Blocklist and Event filters that have messages swapped 😅 @bfishel @machadoum

ashokaditya

Thanks for the chagnes! I have a couple more suggestions. Plus what @dasansol92 pointed out.

x-pack/plugins/security_solution/public/overview/links.ts

x-pack/plugins/security_solution/public/management/links.ts

ashokaditya · 2022-05-17T08:25:08Z

x-pack/plugins/security_solution/public/users/links.ts

+      'A comprehensive overview of user data that enables understanding of authentication and user behavior within your environment.',
+  }),


machadoum · 2022-05-17T08:53:01Z

Hey @ashokaditya and @dasansol92, Thanks for your review and for catching that wrong description. 👏 👏

I implemented all the suggestions except for hostIsolationExceptions and blocklist because I need to check with Design first.

dasansol92

OLM changes LGTM! Only need to clarify the sorting of management items but it can be done in a subsequent pr if this needs to be merged. Thanks for putting all of this together!

dasansol92 · 2022-05-17T09:22:37Z

x-pack/plugins/security_solution/public/management/links.ts

      path: BLOCKLIST_PATH,
      skipUrlState: true,
    },
  ],
 };
+
+export const navigationCategories: NavigationCategories = [


Question: is this exactly the same as the one in landing_pages/constants, if so, could we unify them?

yes, good catch, that was intentionally moved to your team folder, It needs to be removed from landing_pages/constants, will do in my next PR 👍

semd · 2022-05-17T09:40:49Z

@dasansol92 @ashokaditya This PR is blocking me with this. Since the order of two links is the only issue remaining, would it be possible to merge this one, and if @bfishel decides to change it, we create a small separate PR for it? Thanks

kibana-ci · 2022-05-17T10:18:51Z

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`securitySolution`	2920	2934	+14

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`securitySolution`	5.0MB	5.0MB	+8.5KB

Unknown metric groups

miscellaneous assets size

id	before	after	diff
`securitySolution`	1.7MB	1.7MB	+35.0KB

History

💔 Build #45001 failed 67ed319
💔 Build #44981 failed 663f4332533f234ac0c6e283794d858b584788b9
💚 Build #44834 succeeded c151576
💔 Build #44794 failed 3dd4fba3c0268e6be123a3fd8e7af5e6dc19c7e9
💛 Build #44654 was flaky 1449681

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @machadoum

* Update navigation landing pages to use appLinks config * Please code review * align app links changes * Update links descriptions * Rollback title changes * Fix wrong links descriptions * Fix unit tests * Fix description Co-authored-by: semd <sergi.massaneda@elastic.co>

bfishel · 2022-05-17T12:35:11Z

good on the order that @dasansol92 proposed!

* wip I * add alert table state in case * [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix' * add new API to get FeatureID form registrationContext and update UI to use this new API * rm dead code * [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix' * remove unnecessary memo * adds tests for case view helpers * Move http call to API and add tests for getFeatureIds * fix type + unit test * add unit tests + cleanup * add new api integration test for _feature_ids * [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix' * Fix small type creating typescript slowness * remove console log * use import type for validfeatureId * force any to improve typescript performance * Update APM (#132270) Co-authored-by: Renovate Bot <bot@renovateapp.com> * [ResponseOps][Docs] Updating ServiceNow docs with OAuth setup instructions (#131344) * Updating ServiceNow docs. Need screenshots * Adding screenshots * Fix nested screenshots and lists * Tweaks and screenshots * Updates * blergh * Apply suggestions from code review Co-authored-by: Lisa Cawley <lcawley@elastic.co> * Apply suggestions from code review Co-authored-by: Mike Côté <mikecote@users.noreply.github.com> Co-authored-by: lcawl <lcawley@elastic.co> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Mike Côté <mikecote@users.noreply.github.com> * Show polling options when 'Data streams' option is selected in the Console Settings modal. (#132277) * [Osquery] Make Osquery All with All base privillege (#130523) * [XY] Add normalizeTable function to correct works with esdocs (#131917) * Add normalizeTable function to correct works with esdocs * Fix types * Fix types * Fix CI * Fix CI * Some fixes * Remove fallback with min/max value for domain * Added tests * Some refactoring Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Yaroslav Kuznietsov <kuznetsov.yaroslav.yk@gmail.com> * [Osquery] Add default osquery_saved_query objects (#129461) * [Unified Search] Show error message for invalid date filter value (#131290) * feat: added show error message for invalid date * refact: move logic in HOC * feat: refactoring code and added translation * refact show error * refact: show error message * refact: remove translation * refactor: changed menu for show FilterEdit * fix: open/close popover * feat: field.type => KBN_FIELD_TYPES * feat: remove extra code with with input check and refactored filter item * feat: added tests and refactoring code * refact: getFieldValidityAndErrorMessage * feat: return isInvalid checking in valur input type for string, ip * Update navigation landing pages to use appLinks config (#132027) * Update navigation landing pages to use appLinks config * Please code review * align app links changes * Update links descriptions * Rollback title changes * Fix wrong links descriptions * Fix unit tests * Fix description Co-authored-by: semd <sergi.massaneda@elastic.co> * [Cloud Posture] add resource findings page flyout (#132243) * [Discover] Add a tour for Document Explorer (#131125) * [Discover] Add "Take a tour" button to the Document Explorer callout * [Discover] Tmp * [Discover] Add a first Document Explorer tour step * [Discover] Add other Document Explorer tour steps * [Discover] Update tour steps positioning * [Discover] Add gifs to tour steps * [Discover] Refactor how tour steps are registered * [Discover] Add new step to the tour. Update tour steps text. * [Discover] Improve steps positioning * [Discover] Fix positioning for Add field step * [Discover] Add icons to tour steps * [Discover] Reorganize components * [Discover] Skip Columns step when it's not available * [Discover] Rename components * [Discover] Add some tests * [Discover] Fix positioning * [Discover] Fix props * [Discover] Render steps only if the tour is active * [Discover] Update gifs * [Discover] Add image alt text for gifs * [Discover] Tag the Take tour button * [Discover] Update text and tests * [Discover] Add more tests * [Discover] Rename assets directory * [Discover] Fix tour in mobile view. Improve steps positioning and animation. * [Discover] Update text in tour steps * [Discover] Update sort.gif * [Discover] Update image width * Update src/plugins/discover/public/components/discover_tour/discover_tour_provider.tsx Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com> * Update src/plugins/discover/public/components/discover_tour/discover_tour_provider.tsx Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com> * [Discover] Update sort.gif * [Discover] Fix code style Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> * [XY] Add `minTimeBarInterval` arg (#128726) * Added `xAxisInterval` arg * Add validation * Add tests * Rename xAxisInterval to minTimeBarInterval and add validation * Fix imports * Add tests to validation * Fix conflicts * [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix' * Fix tests Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> * do not use barrel imports * do not use barrel import * do not use barrel import * do not use barrel imports * do not use barrel import * import types * Add tests * Fix cases bundle size * Add more tests * [Fleet] Add new API to get current upgrades (#132276) * Add support of Data View switching for Agg-Based visualizations (#132184) * Add support of Data View switching for Agg-Based visualizations * fix CI * add use_date_view_updates * implement sync with state * cleanup * cleanup * cleanup * Update index.ts * fix PR comments * Update use_data_view_updates.ts * Update use_data_view_updates.ts Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> * [Security Solution] Responsive styling fixes (#131951) * [Discover] Add Analytics No Data Page (#131965) * [Discover] Add Analytics No Data Page * Make showEmptyPrompt parameter optional * Remove unused import * Remove unnecessary test * Fix test * Update failing test? * Update failing test * Changing the order of functional tests * Fix error handling * Addressing PR comments Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> * Remove barrel export from public index file * remove barrel export * Re-export missing exports * Turn off feature flag Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Esteban Beltran <esteban.beltran@elastic.co> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: Ying Mao <ying.mao@elastic.co> Co-authored-by: lcawl <lcawley@elastic.co> Co-authored-by: Mike Côté <mikecote@users.noreply.github.com> Co-authored-by: CJ Cenizal <cj.cenizal@elastic.co> Co-authored-by: Tomasz Ciecierski <ciecierskitomek@gmail.com> Co-authored-by: Uladzislau Lasitsa <Uladzislau_Lasitsa@epam.com> Co-authored-by: Yaroslav Kuznietsov <kuznetsov.yaroslav.yk@gmail.com> Co-authored-by: Nodir Latipov <nodir.latypov@gmail.com> Co-authored-by: Pablo Machado <pablo.nevesmachado@elastic.co> Co-authored-by: semd <sergi.massaneda@elastic.co> Co-authored-by: Or Ouziel <or.ouziel@elastic.co> Co-authored-by: Julia Rechkunova <julia.rechkunova@elastic.co> Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com> Co-authored-by: Christos Nasikas <christos.nasikas@elastic.co> Co-authored-by: Nicolas Chaulet <nicolas.chaulet@elastic.co> Co-authored-by: Alexey Antonov <alexwizp@gmail.com> Co-authored-by: Steph Milovic <stephanie.milovic@elastic.co> Co-authored-by: Maja Grubic <maja.grubic@elastic.co>

machadoum commented May 11, 2022

View reviewed changes

x-pack/plugins/security_solution/public/app/translations.ts Outdated Show resolved Hide resolved

machadoum force-pushed the siem-explore-issue-130565-4 branch 2 times, most recently from db509c8 to 208e065 Compare May 11, 2022 13:12

machadoum marked this pull request as ready for review May 11, 2022 13:20

machadoum requested review from a team as code owners May 11, 2022 13:20

machadoum requested review from ashokaditya and dasansol92 May 11, 2022 13:20

machadoum self-assigned this May 11, 2022

machadoum added Team:Threat Hunting Security Solution Threat Hunting Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Explore v8.3.0 labels May 11, 2022

machadoum added the release_note:skip Skip the PR/issue when compiling release notes label May 11, 2022

machadoum force-pushed the siem-explore-issue-130565-4 branch from 208e065 to fe2215f Compare May 11, 2022 15:52

ashokaditya reviewed May 12, 2022

View reviewed changes

x-pack/plugins/security_solution/public/hosts/links.ts Outdated Show resolved Hide resolved

x-pack/plugins/security_solution/public/management/links.ts Outdated Show resolved Hide resolved

x-pack/plugins/security_solution/public/users/links.ts Outdated Show resolved Hide resolved

machadoum marked this pull request as draft May 12, 2022 08:47

machadoum force-pushed the siem-explore-issue-130565-4 branch 2 times, most recently from b684e3d to ac690bc Compare May 12, 2022 11:07

machadoum commented May 12, 2022

View reviewed changes

x-pack/plugins/security_solution/public/common/hooks/use_experimental_features.ts Show resolved Hide resolved

machadoum force-pushed the siem-explore-issue-130565-4 branch 2 times, most recently from 220ede4 to 5599a96 Compare May 12, 2022 11:57

dasansol92 reviewed May 12, 2022

View reviewed changes

x-pack/plugins/security_solution/public/common/hooks/use_experimental_features.ts Show resolved Hide resolved

x-pack/plugins/security_solution/public/landing_pages/pages/manage.tsx Outdated Show resolved Hide resolved

machadoum force-pushed the siem-explore-issue-130565-4 branch from 5599a96 to b8b145e Compare May 12, 2022 13:42

machadoum marked this pull request as ready for review May 12, 2022 15:46

machadoum requested a review from semd May 12, 2022 15:53

semd approved these changes May 12, 2022

View reviewed changes

Please code review

1a4602f

machadoum force-pushed the siem-explore-issue-130565-4 branch from 3dd4fba to 1a4602f Compare May 16, 2022 09:31

semd force-pushed the siem-explore-issue-130565-4 branch from 1a4602f to 1449681 Compare May 16, 2022 10:19

align app links changes

c151576

machadoum force-pushed the siem-explore-issue-130565-4 branch from 1449681 to c151576 Compare May 16, 2022 10:26

machadoum requested review from ashokaditya and dasansol92 May 16, 2022 13:59

ashokaditya reviewed May 16, 2022

View reviewed changes

x-pack/plugins/security_solution/public/landing_pages/components/landing_links_images.tsx Show resolved Hide resolved

x-pack/plugins/security_solution/public/users/links.ts Outdated Show resolved Hide resolved

Update links descriptions

3ec3b11

machadoum force-pushed the siem-explore-issue-130565-4 branch from 663f433 to af101f4 Compare May 16, 2022 16:29

Rollback title changes

67ed319

machadoum force-pushed the siem-explore-issue-130565-4 branch from af101f4 to 67ed319 Compare May 16, 2022 16:31

machadoum requested a review from ashokaditya May 16, 2022 16:35

dasansol92 reviewed May 17, 2022

View reviewed changes

Fix wrong links descriptions

b55192d

ashokaditya reviewed May 17, 2022

View reviewed changes

Fix unit tests

b005fe7

Fix description

fee4d8f

ashokaditya approved these changes May 17, 2022

View reviewed changes

dasansol92 approved these changes May 17, 2022

View reviewed changes

machadoum merged commit 37e4628 into elastic:main May 17, 2022

kibanamachine added the backport:skip This commit does not require backporting label May 17, 2022

semd mentioned this pull request May 17, 2022

[Security Solution] MVP for the new Security side navigation #130023

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update navigation landing pages to use appLinks config #132027

Update navigation landing pages to use appLinks config #132027

machadoum commented May 11, 2022 •

edited

Loading

elasticmachine commented May 11, 2022

elasticmachine commented May 11, 2022

semd left a comment

machadoum commented May 16, 2022 •

edited

Loading

dasansol92 left a comment

dasansol92 May 17, 2022 •

edited

Loading

machadoum May 17, 2022

ashokaditya May 17, 2022 •

edited

Loading

ashokaditya left a comment

ashokaditya May 17, 2022

machadoum commented May 17, 2022 •

edited

Loading

dasansol92 left a comment

dasansol92 May 17, 2022

semd May 17, 2022

semd commented May 17, 2022

kibana-ci commented May 17, 2022

miscellaneous assets size

bfishel commented May 17, 2022

		'A comprehensive overview of user data that enables understanding of authentication and user behavior within your environment.',
		}),

Update navigation landing pages to use appLinks config #132027

Update navigation landing pages to use appLinks config #132027

Conversation

machadoum commented May 11, 2022 • edited Loading

Summary

Checklist

elasticmachine commented May 11, 2022

elasticmachine commented May 11, 2022

semd left a comment

Choose a reason for hiding this comment

machadoum commented May 16, 2022 • edited Loading

dasansol92 left a comment

Choose a reason for hiding this comment

dasansol92 May 17, 2022 • edited Loading

Choose a reason for hiding this comment

machadoum May 17, 2022

Choose a reason for hiding this comment

ashokaditya May 17, 2022 • edited Loading

Choose a reason for hiding this comment

ashokaditya left a comment

Choose a reason for hiding this comment

ashokaditya May 17, 2022

Choose a reason for hiding this comment

machadoum commented May 17, 2022 • edited Loading

dasansol92 left a comment

Choose a reason for hiding this comment

dasansol92 May 17, 2022

Choose a reason for hiding this comment

semd May 17, 2022

Choose a reason for hiding this comment

semd commented May 17, 2022

kibana-ci commented May 17, 2022

💚 Build Succeeded

Metrics [docs]

Module Count

Async chunks

miscellaneous assets size

History

bfishel commented May 17, 2022

machadoum commented May 11, 2022 •

edited

Loading

machadoum commented May 16, 2022 •

edited

Loading

dasansol92 May 17, 2022 •

edited

Loading

ashokaditya May 17, 2022 •

edited

Loading

machadoum commented May 17, 2022 •

edited

Loading