Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Adding UI for question_answering model testing #132033

Merged
merged 3 commits into from
May 16, 2022
Merged

[ML] Adding UI for question_answering model testing #132033

merged 3 commits into from
May 16, 2022

Conversation

jgowdyelastic
Copy link
Member

Adds UI for testing the new question answering model task.

A snippet of input text is displayed, truncated 200 characters either side of the answer text.

image

@jgowdyelastic jgowdyelastic requested a review from a team as a code owner May 11, 2022 14:00
@jgowdyelastic jgowdyelastic self-assigned this May 11, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@peteharverson peteharverson changed the title [ML] Adding UI for question_answering mmodel testing [ML] Adding UI for question_answering model testing May 11, 2022
peteharverson
peteharverson approved these changes May 12, 2022
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
ml 1584 1588 +4

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ml 3.3MB 3.3MB +2.7KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jgowdyelastic

alvarezmelissa87
alvarezmelissa87 approved these changes May 16, 2022
View reviewed changes
Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM ⚡

@jgowdyelastic jgowdyelastic merged commit 0f922e4 into elastic:main May 16, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label May 16, 2022
@jgowdyelastic jgowdyelastic deleted the adding-ui-for-question_answering branch May 16, 2022 19:32
This was referenced May 18, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peteharverson peteharverson peteharverson approved these changes

@alvarezmelissa87 alvarezmelissa87 alvarezmelissa87 approved these changes

Assignees

@jgowdyelastic jgowdyelastic

Labels
backport:skip This commit does not require backporting Feature:3rd Party Models ML 3rd party models :ml release_note:enhancement v8.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jgowdyelastic @elasticmachine @kibana-ci @alvarezmelissa87 @peteharverson @kibanamachine