Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[maps] fix marker size scale issue for counts #132057

Merged
merged 3 commits into from
May 12, 2022
Merged

Conversation

nreese
Copy link
Contributor

@nreese nreese commented May 11, 2022

Fixes #131693

This PR sets the range.min to 1 for count fields since we know that counts can be only positivity integers counting 1,2,3, ...

Forcing the minimum count to 1 instead of the minimum count on screen has the effect of showing circle sizes in better proportion to their values. In the example screen shots below, notice how the markers for the smaller values are much more visible and better reflect relativity of their values.

before

Screen Shot 2022-05-11 at 12 04 08 PM

after

Screen Shot 2022-05-11 at 12 03 24 PM

@nreese nreese added release_note:enhancement [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation backport:skip This commit does not require backporting v8.3.0 labels May 11, 2022
@nreese nreese requested review from jsanz and gvnmagni May 11, 2022 18:11
@nreese nreese marked this pull request as ready for review May 11, 2022 21:15
@nreese nreese requested a review from a team as a code owner May 11, 2022 21:15
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

@nreese nreese requested review from jsanz and gvnmagni and removed request for jsanz and gvnmagni May 11, 2022 21:17
@jsanz
Copy link
Member

jsanz commented May 12, 2022

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
maps 2.5MB 2.5MB +82.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Member

@jsanz jsanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in the CI deploy, works great

@nreese nreese merged commit c9372dc into elastic:main May 12, 2022
@tylersmalley tylersmalley added ci:cloud-deploy Create or update a Cloud deployment and removed ci:deploy-cloud labels Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting ci:cloud-deploy Create or update a Cloud deployment [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation Feature:Maps release_note:enhancement v8.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Maps] Markers size scale issue
8 participants