Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Synthetics] Enhance telemetry for synthetics monitors #132150

Merged
merged 1 commit into from
May 16, 2022
Merged

[Synthetics] Enhance telemetry for synthetics monitors #132150

merged 1 commit into from
May 16, 2022

Conversation

shahzad31
Copy link
Contributor

Summary

Added license information so that we can differentiate between internal and external monitors.

@shahzad31 shahzad31 requested a review from a team as a code owner May 12, 2022 16:15
@shahzad31 shahzad31 self-assigned this May 12, 2022
@shahzad31 shahzad31 added release_note:skip Skip the PR/issue when compiling release notes v8.3.0 labels May 12, 2022
@shahzad31 shahzad31 force-pushed the enhance-telemetry branch from 2232d35 to f9aa980 Compare May 16, 2022 12:11
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #15 / Ingest pipelines app feature controls security "before all" hook in "security"

Metrics [docs]

✅ unchanged

History

  • 💚 Build #44537 succeeded 141e84bca06fe2c6753fb1049cafef5c62edfa22

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @shahzad31

dominiqueclarke
dominiqueclarke approved these changes May 16, 2022
View reviewed changes
Copy link
Contributor

@dominiqueclarke dominiqueclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested only with 1 monitor type, but tested for the full workflow, adding, editing, and deleting.

@shahzad31 shahzad31 merged commit 6edf3dc into elastic:main May 16, 2022
@shahzad31 shahzad31 deleted the enhance-telemetry branch May 16, 2022 16:36
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label May 16, 2022
@shahzad31 shahzad31 added v8.2.1 auto-backport Deprecated - use backport:version if exact versions are needed and removed backport:skip This commit does not require backporting labels May 16, 2022
@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
❌ 8.2 Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 132150

Questions ?

Please refer to the Backport tool documentation

@shahzad31 shahzad31 mentioned this pull request May 16, 2022
Merged
shahzad31 added a commit to shahzad31/kibana that referenced this pull request May 16, 2022
@shahzad31
[Synthetics] Enhance telemetry for synthetics monitors (elastic#132150)
93f5393 
(cherry picked from commit 6edf3dc)
shahzad31 added a commit that referenced this pull request May 16, 2022
@shahzad31
[Synthetics] Enhance telemetry for synthetics monitors (#132150) (#13…
ae54add 
…2275)

(cherry picked from commit 6edf3dc)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dominiqueclarke dominiqueclarke dominiqueclarke approved these changes

Assignees

@shahzad31 shahzad31

Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes v8.2.1 v8.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shahzad31 @kibana-ci @kibanamachine @dominiqueclarke