Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Visualize] Renders no data component if there is no ES data or dataview #132223

Merged
merged 16 commits into from
May 18, 2022
Merged

[Visualize] Renders no data component if there is no ES data or dataview #132223

merged 16 commits into from
May 18, 2022

Conversation

stratoula
Copy link
Contributor

@stratoula stratoula commented May 16, 2022 •
edited
Loading

Summary

Part of #132146

It implements the no data component to the visualize library.
image

This component is loaded when:

  • there is no es data
  • there is ES data but no dataviews

How to test

  • Start a new kibana instance (with the functional test server for example) with no data. Go to visualize. You will see the integrations component
  • Add some sample data, go to dataviews management page and remove the dataviews. You will see the no dataviews component.

Checklist

stratoula
stratoula commented May 17, 2022
View reviewed changes
test/functional/apps/dashboard/group4/dashboard_save.ts
@@ -125,6 +126,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
});

it('Does not show dashboard save modal when on quick save', async function () {
await esArchiver.loadIfNeeded('test/functional/fixtures/es_archiver/logstash_functional');
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ℹ️ I found out that on this test, there were no es data loaded, and with the change done on this PR, we need es data in order to have access to the viz editor. So I am loading them on this test.

stratoula
stratoula commented May 17, 2022
View reviewed changes
x-pack/test/functional/apps/maps/group4/visualize_create_menu.js
await security.testUser.setRoles(['global_maps_all', 'global_visualize_all'], {
skipBrowserRefresh: true,
});
await security.testUser.setRoles(
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ℹ️ I am adding another role to this user here. The test_logstash_reader adds permission to this user to the logstash index. The new no data component for visualize needs ES data and dataviews to exist.

@stratoula stratoula added Feature:Vis Editor Visualization editor issues v8.3.0 release_note:enhancement backport:skip This commit does not require backporting labels May 17, 2022
@stratoula stratoula added the Team:Visualizations Visualization editors, elastic-charts and infrastructure label May 17, 2022
@stratoula stratoula marked this pull request as ready for review May 17, 2022 13:57
@stratoula stratoula requested a review from a team May 17, 2022 13:57
@stratoula stratoula requested review from a team as code owners May 17, 2022 13:57
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

@stratoula stratoula removed the request for review from a team May 17, 2022 13:58
nreese
nreese approved these changes May 17, 2022
View reviewed changes
Copy link
Contributor

@nreese nreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kibana-gis changes LGTM
code review

flash1293
flash1293 approved these changes May 17, 2022
View reviewed changes
Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and all the cases work as expected, LGTM!

  • No data / data but no data view cases are handled correctly
  • Context of saved vis is not lost after data view creation

src/plugins/visualizations/public/visualize_app/app.tsx Outdated Show resolved Hide resolved
ThomThomson
ThomThomson approved these changes May 17, 2022
View reviewed changes
Copy link
Contributor

@ThomThomson ThomThomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Presentation team changes LGTM!

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
visualizations 219 326 +107

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
visualizations 167.8KB 305.5KB +137.7KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
visualizations 46.5KB 46.5KB +2.0B
Unknown metric groups

async chunk count

id before after diff
visualizations 11 18 +7

miscellaneous assets size

id before after diff
visualizations 0.0B 161.8KB +161.8KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

ryankeairns
ryankeairns approved these changes May 18, 2022
View reviewed changes
Copy link
Contributor

@ryankeairns ryankeairns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to have this shared :)

@stratoula stratoula merged commit 465c419 into elastic:main May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebelga sebelga sebelga left review comments

@majagrubic majagrubic majagrubic left review comments

@ThomThomson ThomThomson ThomThomson approved these changes

@flash1293 flash1293 flash1293 approved these changes

@ryankeairns ryankeairns ryankeairns approved these changes

@nreese nreese nreese approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting Feature:Vis Editor Visualization editor issues release_note:enhancement Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@stratoula @elasticmachine @kibana-ci @nreese @ryankeairns @flash1293 @majagrubic @sebelga @ThomThomson