Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] [Endpoint] Allow add endpoint event filter option from users events tab #132238

Merged
merged 2 commits into from
May 16, 2022
Merged

[Security Solution] [Endpoint] Allow add endpoint event filter option from users events tab #132238

merged 2 commits into from
May 16, 2022

Conversation

dasansol92
Copy link
Contributor

Summary

Screenshot 2022-05-16 at 14 23 41

For maintainers

@dasansol92 dasansol92 added release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution auto-backport Deprecated - use backport:version if exact versions are needed v8.3.0 v8.2.1 labels May 16, 2022
@dasansol92 dasansol92 requested a review from a team May 16, 2022 12:25
@dasansol92 dasansol92 requested a review from a team as a code owner May 16, 2022 12:25
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-onboarding-and-lifecycle-mgt (Team:Onboarding and Lifecycle Mgt)

@dasansol92 dasansol92 mentioned this pull request May 16, 2022
Closed
@dasansol92 dasansol92 requested review from a team, joeypoon, paul-tavares and ashokaditya and removed request for a team and paul-tavares May 16, 2022 13:29
michaelolo24
michaelolo24 reviewed May 16, 2022
View reviewed changes
...ution/public/detections/components/alerts_table/timeline_actions/alert_context_menu.test.tsx
@@ -188,6 +188,36 @@ describe('InvestigateInResolverAction', () => {
expect(wrapper.find(addEndpointEventFilterButton).first().exists()).toEqual(true);
expect(wrapper.find(addEndpointEventFilterButton).first().props().disabled).toEqual(true);
});

test('it enables AddEndpointEventFilter when timeline id is user events page', () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding these tests!

michaelolo24
michaelolo24 approved these changes May 16, 2022
View reviewed changes
Copy link
Contributor

@michaelolo24 michaelolo24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 5.0MB 5.0MB +40.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

ashokaditya
ashokaditya approved these changes May 16, 2022
View reviewed changes
...ution/public/detections/components/alerts_table/timeline_actions/alert_context_menu.test.tsx
@@ -209,6 +239,19 @@ describe('InvestigateInResolverAction', () => {
expect(wrapper.find(addEndpointEventFilterButton).first().exists()).toEqual(true);
expect(wrapper.find(addEndpointEventFilterButton).first().props().disabled).toEqual(true);
});

test('it disables AddEndpointEventFilter when timeline id is user events page but cannot acces endpoint management', () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: access

@dasansol92 dasansol92 merged commit b5d8f51 into elastic:main May 16, 2022
kibanamachine pushed a commit that referenced this pull request May 16, 2022
@dasansol92
[Security Solution] [Endpoint] Allow add endpoint event filter option…
cc4a03f 
… from users events tab (#132238)

* Allow add endpoint event filter option from users events tab

* Updates var name

(cherry picked from commit b5d8f51)
@kibanamachine kibanamachine mentioned this pull request May 16, 2022
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.2

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request May 16, 2022
@kibanamachine @dasansol92
[Security Solution] [Endpoint] Allow add endpoint event filter option…
915bf7b 
… from users events tab (#132238) (#132254)

* Allow add endpoint event filter option from users events tab

* Updates var name

(cherry picked from commit b5d8f51)

Co-authored-by: David Sánchez <david.sanchezsoler@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinlog kevinlog kevinlog approved these changes

@michaelolo24 michaelolo24 michaelolo24 approved these changes

@joeypoon joeypoon joeypoon approved these changes

@ashokaditya ashokaditya ashokaditya approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v8.2.1 v8.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@dasansol92 @elasticmachine @kibana-ci @kibanamachine @ashokaditya @joeypoon @michaelolo24 @kevinlog