Solution nav add flex column styles #132252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
semd
added
release_note:skip
|
Pinging @elastic/security-threat-hunting (Team:Threat Hunting) |
cchaos
reviewed
May 16, 2022
Comment on lines
21
to
23
|
|
||
| display: flex; | ||
| flex-direction: column; |
There was a problem hiding this comment.
Can you move this up to before the breakpoint mixin (line 13) otherwise it's hard to follow what styles are being applied directly to the selector.
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @semd |
cchaos
approved these changes
May 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This change is needed by #130023
It will be used in this PR #132210
The new Security Solution side nav needs to place some items at the bottom of the container, this change is needed to position them correctly. This style change is unnoticeable for the rest of the integrations.