Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.2] [Security Solution] Remove sourcerer browser fields hover actions to help performance (#131363) #132261

Merged
merged 3 commits into from
May 16, 2022

Conversation

oatkiller
Copy link
Contributor

Backport

This will backport the following commits from main to 8.2:

Questions ?

Please refer to the Backport tool documentation

…help performance (elastic#131363)

* Batch setState calls to make sure all state updates are applied evenly

* Remove sourcerer hook from useHoverActions and pass needed fields as props

* Update snapshots, remove ReactDOM batching

* Make row renderers aggregatable where appropriate

* add pagination to details table

* Fix hover actions on host/network details

* Remove unneeded props

* fix table pagination tests

* update test

* Show top n for authentications and threat indicator match rules

* Fix anomaly score, entity, influence, and user id show top N

* Pass props on wrapper and not data provider

* Add missing row renderer draggables to use top N props

* Update snapshots

* Pr feedback

Co-authored-by: Michael Olorunnisola <michael.olorunnisola@elastic.co>
Co-authored-by: Robert Austin <robert.austin@elastic.co>
(cherry picked from commit f3c1ad7)

# Conflicts:
#	x-pack/plugins/security_solution/public/common/components/authentication/helpers.tsx
#	x-pack/plugins/security_solution/public/common/lib/cell_actions/expanded_cell_value_actions.tsx
@oatkiller oatkiller enabled auto-merge (squash) May 16, 2022 16:15
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 4.9MB 4.9MB +6.1KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@oatkiller oatkiller merged commit 6fdb90c into elastic:8.2 May 16, 2022
@oatkiller oatkiller deleted the backport/8.2/pr-131363 branch May 16, 2022 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants