Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ILM] Add warnings for managed system policies #132269

Merged
merged 11 commits into from
May 20, 2022
Merged

[ILM] Add warnings for managed system policies #132269

Show file tree
Hide file tree
Changes from 10 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
af09341
Add warnings to system/managed policies
qn895 May 16, 2022
70b9267
Fix translations, policies
qn895 May 16, 2022
47d9e73
Add jest tests
qn895 May 18, 2022
af09cda
Add jest tests to assert new toggle behavior
qn895 May 18, 2022
06c968b
Merge remote-tracking branch 'upstream/main' into ilm-show-managed-ba…
qn895 May 18, 2022
ac47b02
Add jest tests for edit policy callout
qn895 May 18, 2022
6ccf6e1
Fix snapshot
qn895 May 18, 2022
e36d273
[ML] Update jest tests with helper, rename helper for clarity
qn895 May 18, 2022
7ba9009
[ML] Add hook for local storage to remember toggle setting
qn895 May 18, 2022
ed6149d
[ML] Fix naming
qn895 May 18, 2022
66cc74b
Merge branch 'main' into ilm-show-managed-badge-and-warnings
kibanamachine May 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
64 changes: 32 additions & 32 deletions x-pack/plugins/index_lifecycle_management/__jest__/__snapshots__/policy_table.test.tsx.snap
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

23 changes: 23 additions & 0 deletions ...k/plugins/index_lifecycle_management/__jest__/client_integration/edit_policy/constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,6 +221,29 @@ export const POLICY_WITH_KNOWN_AND_UNKNOWN_FIELDS = {
name: POLICY_NAME,
} as any as PolicyFromES;

export const POLICY_MANAGED_BY_ES: PolicyFromES = {
version: 1,
modifiedDate: Date.now().toString(),
policy: {
name: POLICY_NAME,
phases: {
hot: {
min_age: '0ms',
actions: {
rollover: {
max_age: '30d',
max_primary_shard_size: '50gb',
},
},
},
},
_meta: {
managed: true,
},
},
name: POLICY_NAME,
};

export const getGeneratedPolicies = (): PolicyFromES[] => {
const policy = {
phases: {
Expand Down
15 changes: 14 additions & 1 deletion ...ifecycle_management/__jest__/client_integration/edit_policy/features/edit_warning.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import { act } from 'react-dom/test-utils';
import { TestBed } from '@kbn/test-jest-helpers';
import { setupEnvironment } from '../../helpers';
import { initTestBed } from '../init_test_bed';
import { getDefaultHotPhasePolicy, POLICY_NAME } from '../constants';
import { getDefaultHotPhasePolicy, POLICY_NAME, POLICY_MANAGED_BY_ES } from '../constants';

describe('<EditPolicy /> edit warning', () => {
let testBed: TestBed;
Expand Down Expand Up @@ -54,6 +54,19 @@ describe('<EditPolicy /> edit warning', () => {
expect(exists('editWarning')).toBe(true);
});

test('an edit warning callout is shown for an existing, managed policy', async () => {
httpRequestsMockHelpers.setLoadPolicies([POLICY_MANAGED_BY_ES]);

await act(async () => {
testBed = await initTestBed(httpSetup);
});
const { exists, component } = testBed;
component.update();

expect(exists('editWarning')).toBe(true);
expect(exists('editManagedPolicyCallOut')).toBe(true);
});

test('no indices link if no indices', async () => {
httpRequestsMockHelpers.setLoadPolicies([
{ ...getDefaultHotPhasePolicy(POLICY_NAME), indices: [] },
Expand Down
Loading