Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] Swap Fleet Server tabs to EuiButtonGroup #132274

Merged
merged 3 commits into from
May 17, 2022

Conversation

kpollich
Copy link
Member

Summary

Fixes #130888

Convert EuiTabs UI in Fleet Server instructions/flyout to EuiButtonGroup to avoid "double tab" layout issue.

image

@kpollich kpollich added release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.3.0 labels May 16, 2022
@kpollich kpollich requested a review from a team as a code owner May 16, 2022 18:36
@kpollich kpollich self-assigned this May 16, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

Copy link
Member

@nchaulet nchaulet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@kpollich kpollich enabled auto-merge (squash) May 16, 2022 18:51
@@ -80,6 +80,11 @@ describe('Fleet startup', () => {
cy.getBySel('fleetServerFlyoutTab-advanced').click();
cy.getBySel('createFleetServerPolicyBtn').click();

// Wait until the success callout is shown before navigating away
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not really sure how these cypress tests were working before these changes, but they should be good now.

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 704.9KB 704.9KB +11.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @kpollich

@kpollich kpollich merged commit 3fafa6c into elastic:main May 17, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label May 17, 2022
@kpollich kpollich deleted the 130888-swap-tabs-to-button-group branch May 17, 2022 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Fleet] Convert Fleet Server flyout tabs to EuiButtonGroup
5 participants