[Cloud Posture] Rule flyout updates #132327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JordanSh
added
release_note:skip
JordanSh
force-pushed
the
rule-flyout-updates
branch
from
64f8c60 to
931f0ef
Compare
|
Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security Posture) |
orouz
approved these changes
May 17, 2022
| @@ -152,7 +91,7 @@ const RuleOverviewTab = ({ rule, toggleRule }: { rule: RuleSavedObject; toggleRu | |||
| </span> | |||
| </EuiFlexItem> | |||
| <EuiFlexItem> | |||
| <EuiDescriptionList compressed={false} listItems={getOverviewCard(rule)} /> | |||
| <EuiDescriptionList listItems={getRuleList(rule.attributes)} /> | |||
There was a problem hiding this comment.
is there a difference now that this one doesn't have compressed=false ?
There was a problem hiding this comment.
no, false is the default
JordanSh
force-pushed
the
rule-flyout-updates
branch
from
877843e to
9f62773
Compare
JordanSh
force-pushed
the
rule-flyout-updates
branch
2 times, most recently
from
cd0fc4d to
7af8dc8
Compare
JordanSh
force-pushed
the
rule-flyout-updates
branch
from
7af8dc8 to
a10e7fd
Compare
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @JordanSh |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
RuleandOverview -> Remediationsections in the findings flyout.So basically every change we do in the findings flyout at those sections, we automatically get it in the rule flyout as well.
checked with @tinnytintin10 and he liked it :)
Sectioncolumn was renamed toCIS Sectionand now displays data