Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated trimet.vehicleID from Integer to Keyword #132425

Merged
merged 12 commits into from
May 18, 2022
Merged

Updated trimet.vehicleID from Integer to Keyword #132425

merged 12 commits into from
May 18, 2022

Conversation

jamesagarside
Copy link
Contributor

Updated trimet.vehicleID from Integer to Keyword as when using an integer type as entity while creating geo-alerts, the alert fails with the following error.

rule execution failure: .geo-containment:13cb57d0-d5d0-11ec-9011-99e1f9059f25: 'Bus Alerts - Construction Zones' - Alert instance execution has already been scheduled, cannot schedule twice

Fix discovered by @nickpeihl

@jamesagarside jamesagarside requested a review from nickpeihl May 18, 2022 13:15
nickpeihl
nickpeihl approved these changes May 18, 2022
View reviewed changes
Copy link
Member

@nickpeihl nickpeihl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a couple suggestions for changing other mappings.

The conflict with the main branch need to be resolved, but otherwise lgtm.

docs/maps/asset-tracking-tutorial.asciidoc Outdated Show resolved Hide resolved
docs/maps/asset-tracking-tutorial.asciidoc Outdated Show resolved Hide resolved
docs/maps/asset-tracking-tutorial.asciidoc Outdated Show resolved Hide resolved
docs/maps/asset-tracking-tutorial.asciidoc Outdated Show resolved Hide resolved
jamesagarside and others added 4 commits May 18, 2022 14:56
@jamesagarside @nickpeihl
Update docs/maps/asset-tracking-tutorial.asciidoc
1b8a5b6 
Co-authored-by: Nick Peihl <nick.peihl@elastic.co>
@jamesagarside @nickpeihl
Update docs/maps/asset-tracking-tutorial.asciidoc
0ff8d1f 
Co-authored-by: Nick Peihl <nick.peihl@elastic.co>
@jamesagarside @nickpeihl
Update docs/maps/asset-tracking-tutorial.asciidoc
e86415d 
Co-authored-by: Nick Peihl <nick.peihl@elastic.co>
@jamesagarside @nickpeihl
Update docs/maps/asset-tracking-tutorial.asciidoc
d020df2 
Co-authored-by: Nick Peihl <nick.peihl@elastic.co>
@jamesagarside jamesagarside enabled auto-merge (squash) May 18, 2022 13:57
@jamesagarside jamesagarside disabled auto-merge May 18, 2022 14:11
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jamesagarside jamesagarside added auto-backport Deprecated - use backport:version if exact versions are needed backport-v8.0.0 v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v8.1.0 v8.2.0 v8.3.0 and removed auto-backport Deprecated - use backport:version if exact versions are needed backport-v8.0.0 labels May 18, 2022
@jamesagarside jamesagarside enabled auto-merge (squash) May 18, 2022 14:12
@jamesagarside jamesagarside merged commit 956703a into main May 18, 2022
@jamesagarside jamesagarside deleted the asset-tracking-tutorial-alert-body branch May 18, 2022 14:20
kibanamachine pushed a commit that referenced this pull request May 18, 2022
@jamesagarside
Updated trimet.vehicleID from Integer to Keyword (#132425)
2e643c4 
* updated tutorial to use Filebeat and Datastreams rather than Logstash and a static index

* Fixed pipeline issue when inCongestion is null the pipeline fails. Now if null its set as false

* Fixed pipeline issue when inCongestion is null the pipeline fails. Now if null its set as false

* Corrected minor mistakes in docs

* Changed trimet.vehicleID from int to keyword

* Update docs/maps/asset-tracking-tutorial.asciidoc

Co-authored-by: Nick Peihl <nick.peihl@elastic.co>

* Update docs/maps/asset-tracking-tutorial.asciidoc

Co-authored-by: Nick Peihl <nick.peihl@elastic.co>

* Update docs/maps/asset-tracking-tutorial.asciidoc

Co-authored-by: Nick Peihl <nick.peihl@elastic.co>

* Update docs/maps/asset-tracking-tutorial.asciidoc

Co-authored-by: Nick Peihl <nick.peihl@elastic.co>

Co-authored-by: Nick Peihl <nick.peihl@elastic.co>
(cherry picked from commit 956703a)
@kibanamachine kibanamachine mentioned this pull request May 18, 2022
Merged
kibanamachine pushed a commit that referenced this pull request May 18, 2022
@jamesagarside
Updated trimet.vehicleID from Integer to Keyword (#132425)
e3fa5cc 
* updated tutorial to use Filebeat and Datastreams rather than Logstash and a static index

* Fixed pipeline issue when inCongestion is null the pipeline fails. Now if null its set as false

* Fixed pipeline issue when inCongestion is null the pipeline fails. Now if null its set as false

* Corrected minor mistakes in docs

* Changed trimet.vehicleID from int to keyword

* Update docs/maps/asset-tracking-tutorial.asciidoc

Co-authored-by: Nick Peihl <nick.peihl@elastic.co>

* Update docs/maps/asset-tracking-tutorial.asciidoc

Co-authored-by: Nick Peihl <nick.peihl@elastic.co>

* Update docs/maps/asset-tracking-tutorial.asciidoc

Co-authored-by: Nick Peihl <nick.peihl@elastic.co>

* Update docs/maps/asset-tracking-tutorial.asciidoc

Co-authored-by: Nick Peihl <nick.peihl@elastic.co>

Co-authored-by: Nick Peihl <nick.peihl@elastic.co>
(cherry picked from commit 956703a)
@kibanamachine kibanamachine mentioned this pull request May 18, 2022
Merged
kibanamachine pushed a commit that referenced this pull request May 18, 2022
@jamesagarside
Updated trimet.vehicleID from Integer to Keyword (#132425)
eba179b 
* updated tutorial to use Filebeat and Datastreams rather than Logstash and a static index

* Fixed pipeline issue when inCongestion is null the pipeline fails. Now if null its set as false

* Fixed pipeline issue when inCongestion is null the pipeline fails. Now if null its set as false

* Corrected minor mistakes in docs

* Changed trimet.vehicleID from int to keyword

* Update docs/maps/asset-tracking-tutorial.asciidoc

Co-authored-by: Nick Peihl <nick.peihl@elastic.co>

* Update docs/maps/asset-tracking-tutorial.asciidoc

Co-authored-by: Nick Peihl <nick.peihl@elastic.co>

* Update docs/maps/asset-tracking-tutorial.asciidoc

Co-authored-by: Nick Peihl <nick.peihl@elastic.co>

* Update docs/maps/asset-tracking-tutorial.asciidoc

Co-authored-by: Nick Peihl <nick.peihl@elastic.co>

Co-authored-by: Nick Peihl <nick.peihl@elastic.co>
(cherry picked from commit 956703a)
@kibanamachine kibanamachine mentioned this pull request May 18, 2022
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.0
✅ 8.1
✅ 8.2

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request May 18, 2022
@kibanamachine @jamesagarside
Updated trimet.vehicleID from Integer to Keyword (#132425) (#132434)
344800f 
* updated tutorial to use Filebeat and Datastreams rather than Logstash and a static index

* Fixed pipeline issue when inCongestion is null the pipeline fails. Now if null its set as false

* Fixed pipeline issue when inCongestion is null the pipeline fails. Now if null its set as false

* Corrected minor mistakes in docs

* Changed trimet.vehicleID from int to keyword

* Update docs/maps/asset-tracking-tutorial.asciidoc

Co-authored-by: Nick Peihl <nick.peihl@elastic.co>

* Update docs/maps/asset-tracking-tutorial.asciidoc

Co-authored-by: Nick Peihl <nick.peihl@elastic.co>

* Update docs/maps/asset-tracking-tutorial.asciidoc

Co-authored-by: Nick Peihl <nick.peihl@elastic.co>

* Update docs/maps/asset-tracking-tutorial.asciidoc

Co-authored-by: Nick Peihl <nick.peihl@elastic.co>

Co-authored-by: Nick Peihl <nick.peihl@elastic.co>
(cherry picked from commit 956703a)

Co-authored-by: James Garside <james@jgarside.co.uk>
kibanamachine added a commit that referenced this pull request May 18, 2022
@kibanamachine @jamesagarside
Updated trimet.vehicleID from Integer to Keyword (#132425) (#132436)
21c369e 
* updated tutorial to use Filebeat and Datastreams rather than Logstash and a static index

* Fixed pipeline issue when inCongestion is null the pipeline fails. Now if null its set as false

* Fixed pipeline issue when inCongestion is null the pipeline fails. Now if null its set as false

* Corrected minor mistakes in docs

* Changed trimet.vehicleID from int to keyword

* Update docs/maps/asset-tracking-tutorial.asciidoc

Co-authored-by: Nick Peihl <nick.peihl@elastic.co>

* Update docs/maps/asset-tracking-tutorial.asciidoc

Co-authored-by: Nick Peihl <nick.peihl@elastic.co>

* Update docs/maps/asset-tracking-tutorial.asciidoc

Co-authored-by: Nick Peihl <nick.peihl@elastic.co>

* Update docs/maps/asset-tracking-tutorial.asciidoc

Co-authored-by: Nick Peihl <nick.peihl@elastic.co>

Co-authored-by: Nick Peihl <nick.peihl@elastic.co>
(cherry picked from commit 956703a)

Co-authored-by: James Garside <james@jgarside.co.uk>
kibanamachine added a commit that referenced this pull request May 18, 2022
@kibanamachine @jamesagarside
Updated trimet.vehicleID from Integer to Keyword (#132425) (#132435)
f810241 
* updated tutorial to use Filebeat and Datastreams rather than Logstash and a static index

* Fixed pipeline issue when inCongestion is null the pipeline fails. Now if null its set as false

* Fixed pipeline issue when inCongestion is null the pipeline fails. Now if null its set as false

* Corrected minor mistakes in docs

* Changed trimet.vehicleID from int to keyword

* Update docs/maps/asset-tracking-tutorial.asciidoc

Co-authored-by: Nick Peihl <nick.peihl@elastic.co>

* Update docs/maps/asset-tracking-tutorial.asciidoc

Co-authored-by: Nick Peihl <nick.peihl@elastic.co>

* Update docs/maps/asset-tracking-tutorial.asciidoc

Co-authored-by: Nick Peihl <nick.peihl@elastic.co>

* Update docs/maps/asset-tracking-tutorial.asciidoc

Co-authored-by: Nick Peihl <nick.peihl@elastic.co>

Co-authored-by: Nick Peihl <nick.peihl@elastic.co>
(cherry picked from commit 956703a)

Co-authored-by: James Garside <james@jgarside.co.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickpeihl nickpeihl nickpeihl approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed docs release_note:skip Skip the PR/issue when compiling release notes v8.0.0 v8.1.0 v8.2.0 v8.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jamesagarside @kibana-ci @kibanamachine @nickpeihl