Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Maps] fix Cannot open Lens editor in airgapped environment #132429

Merged
merged 2 commits into from
May 18, 2022
Merged

[Maps] fix Cannot open Lens editor in airgapped environment #132429

merged 2 commits into from
May 18, 2022

Conversation

nreese
Copy link
Contributor

@nreese nreese commented May 18, 2022

Fixes #132408

PR wraps all calls to getEmsFileLayers and getEmsTmsServices with try/catch block. These calls throw when EMS is unavailable.

To test

  • Start kibana server
  • Disconnect computer from network
  • Open Kibana in browser and create new lens visualization. Lens should open and regionmap chart will provide disabled "EMS boundaries" select with message about being unable to access EMS and no suggestions for regionmap chart will be provided.

Screen Shot 2022-05-18 at 7 15 28 AM

@nreese nreese added release_note:fix [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.3.0 labels May 18, 2022
@nreese nreese requested a review from a team as a code owner May 18, 2022 13:42
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

@nreese nreese requested review from nickpeihl and flash1293 May 18, 2022 13:43
@nreese
Copy link
Contributor Author

nreese commented May 18, 2022

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
maps 2.5MB 2.5MB +336.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
maps 78.1KB 78.1KB +62.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@nreese nreese added v8.2.2 auto-backport Deprecated - use backport:version if exact versions are needed labels May 18, 2022
nickpeihl
nickpeihl approved these changes May 18, 2022
View reviewed changes
Copy link
Member

@nickpeihl nickpeihl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

code review and tested in chrome with and without network. also tested with ems-server.

@nreese nreese merged commit 03617b4 into elastic:main May 18, 2022
@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
❌ 8.2 Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 132429

Questions ?

Please refer to the Backport tool documentation

nreese added a commit to nreese/kibana that referenced this pull request May 18, 2022
@nreese
[Maps] fix Cannot open Lens editor in airgapped environment (elastic#…
3baa7cb 
…132429)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 03617b4)

# Conflicts:
#	x-pack/plugins/maps/public/lens/choropleth_chart/expression_renderer.tsx
#	x-pack/plugins/maps/public/lens/choropleth_chart/setup.ts
@nreese nreese mentioned this pull request May 18, 2022
Merged
@nreese
Copy link
Contributor Author

nreese commented May 18, 2022

8.2 #132463

nreese added a commit that referenced this pull request May 18, 2022
@nreese
[8.2] [Maps] fix Cannot open Lens editor in airgapped environment (#1…
7131e30 
…32429) (#132463)

* [Maps] fix Cannot open Lens editor in airgapped environment (#132429)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 03617b4)

# Conflicts:
#	x-pack/plugins/maps/public/lens/choropleth_chart/expression_renderer.tsx
#	x-pack/plugins/maps/public/lens/choropleth_chart/setup.ts

* eslint
@nreese nreese added v8.2.1 and removed v8.2.2 labels May 19, 2022
@nreese
Copy link
Contributor Author

nreese commented May 19, 2022

Another build candidate for 8.2.1 was created. This BC included this fix so it will be in 8.2.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickpeihl nickpeihl nickpeihl approved these changes

@flash1293 flash1293 Awaiting requested review from flash1293

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation Feature:Maps release_note:fix Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.2.1 v8.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Maps][Lens] Cannot open Lens editor in airgapped environment
6 participants
@nreese @elasticmachine @kibana-ci @kibanamachine @nickpeihl @sophiec20