Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KibanaPageTemplateSolutionNavAvatar] Increase specificity of styles #132448

Merged
merged 1 commit into from
May 19, 2022

Conversation

cchaos
Copy link
Contributor

@cchaos cchaos commented May 18, 2022

Mostly a temporary fix until #132363 is figured out

Since EUI switched to Emotion, we've converted just a few components like EuiAvatar. But there's a slight import of styles ordering issue that causes some custom Kibana styles to not override EUI's styles because of cascade order. This one I just fixed specifically by increasing the specificity for the stylized xxl version.

BEFORE
Screen Shot 2022-05-18 at 11 52 25 AM

AFTER
Screen Shot 2022-05-18 at 11 52 17 AM

Checklist

@cchaos cchaos requested a review from a team May 18, 2022 15:57
@cchaos cchaos added release_note:skip Skip the PR/issue when compiling release notes v8.3.0 Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) labels May 18, 2022
@cchaos cchaos enabled auto-merge (squash) May 18, 2022 16:26
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
kibanaReact 59.6KB 59.7KB +66.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cchaos cchaos merged commit 51acefc into elastic:main May 19, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label May 19, 2022
@cchaos cchaos deleted the solution_avatar/fix_styles branch May 19, 2022 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) v8.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants