[Fleet] Lazy load package icons in integrations grid #132455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshdover
added
release_note:skip
|
Pinging @elastic/fleet (Team:Fleet) |
|
Looks like we did not sync correctly on this one, #132450 |
nchaulet
approved these changes
May 18, 2022
kibanamachine
pushed a commit
that referenced
this pull request
May 18, 2022
(cherry picked from commit 6cf8ebf)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
May 18, 2022
joshdover
added a commit
to joshdover/kibana
that referenced
this pull request
May 30, 2022
(cherry picked from commit 6cf8ebf) # Conflicts: # x-pack/plugins/fleet/public/components/package_icon.tsx
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
kibanamachine
added
the
backport missing
joshdover
added a commit
that referenced
this pull request
Jun 2, 2022
…#133165) * [Fleet] Lazy load package icons in integrations grid (#132455) (cherry picked from commit 6cf8ebf) # Conflicts: # x-pack/plugins/fleet/public/components/package_icon.tsx * Fix linting Co-authored-by: Jen Huang <its.jenetic@gmail.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
kibanamachine
removed
the
backport missing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolve #122660
Will prevent the package icons from loading until they're near the viewport when scrolling. Reduces request backlog/queueing on HTTP/1.1 connections (which is only what Kibana supports).