Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.17] [Security Solution] Fixes sorting and tooltips on columns for non-ECS fields that are only one level deep (#132570) #132665

Merged
merged 2 commits into from
May 21, 2022
Merged

[7.17] [Security Solution] Fixes sorting and tooltips on columns for non-ECS fields that are only one level deep (#132570) #132665

merged 2 commits into from
May 21, 2022

Conversation

andrew-goldstein
Copy link
Contributor

Backport

This will backport the following commits from main to 7.17:

Questions ?

Please refer to the Backport tool documentation

@andrew-goldstein
## [Security Solution] Fixes sorting and tooltips on columns for non-…
0a84c04 
…ECS fields that are only one level deep

This PR fixes <elastic#132490>, an issue where Timeline columns for non-ECS fields that are only one level deep couldn't be sorted, and displayed incomplete metadata in the column's tooltip.

### Before

![test_field_1_actual_tooltip](https://user-images.githubusercontent.com/4459398/169208299-51d9296a-15e1-4eb0-bc31-a0df6a63f0c5.png)

_Before: The column is **not** sortable, and the tooltip displays incomplete metadata_

### After

![after](https://user-images.githubusercontent.com/4459398/169414767-7274a795-015f-4805-8c3f-b233ead994ea.png)

_After: The column is sortable, and the tooltip displays the expected metadata_

### Desk testing

See the _Steps to reproduce_ section of <elastic#132490> for testing details.

(cherry picked from commit 788dd2e)
@andrew-goldstein andrew-goldstein enabled auto-merge (squash) May 20, 2022 22:42
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 4.6MB 4.6MB +103.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@andrew-goldstein andrew-goldstein merged commit a5d73c8 into elastic:7.17 May 21, 2022
@andrew-goldstein andrew-goldstein deleted the backport/7.17/pr-132570 branch May 23, 2022 15:36
@andrew-goldstein andrew-goldstein mentioned this pull request May 23, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrew-goldstein @kibana-ci