Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Discover] Improve and unskip functional test of hiding the histogram #132768

Merged
merged 2 commits into from
May 25, 2022
Merged

[Discover] Improve and unskip functional test of hiding the histogram #132768

merged 2 commits into from
May 25, 2022

Conversation

kertal
Copy link
Member

@kertal kertal commented May 24, 2022 •
edited
Loading

Summary

Fixing the test of hiding the histogram by adding a little mouse movement. It failed because the button to click was hidden by an overlapping popover but the button starting the search.

Flaky test runner, 100 runs: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/662

Fixes #132288

Checklist

@kertal kertal added Feature:Discover Discover Application Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. labels May 24, 2022
@kertal kertal self-assigned this May 24, 2022
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @kertal

@kertal kertal changed the title [Discover] Move mouse to element to prevent overlapping by popover [Discover] Improve and unskip functional test of hidding th e ·ts Move mouse to element to prevent overlapping by popover May 24, 2022
@kertal kertal changed the title [Discover] Improve and unskip functional test of hidding th e ·ts Move mouse to element to prevent overlapping by popover [Discover] Improve and unskip functional test of hidding the histogram May 24, 2022
@kertal kertal changed the title [Discover] Improve and unskip functional test of hidding the histogram [Discover] Improve and unskip functional test of hiding the histogram May 24, 2022
@kertal kertal marked this pull request as ready for review May 24, 2022 15:50
@kertal kertal requested a review from a team as a code owner May 24, 2022 15:50
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

jughosta
jughosta approved these changes May 24, 2022
View reviewed changes
Copy link
Contributor

@jughosta jughosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! 👍

@kertal kertal added v8.3.0 v8.4.0 release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting and removed v8.4.0 labels May 25, 2022
@kertal kertal merged commit 66c293f into elastic:main May 25, 2022
@kertal kertal deleted the discover-fix-functional-hidden-chart branch June 9, 2022 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jughosta jughosta jughosta approved these changes

Assignees

@kertal kertal

Labels
backport:skip This commit does not require backporting Feature:Discover Discover Application release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. v8.3.0
Projects
None yet
Milestone
No milestone
4 participants
@kertal @kibana-ci @elasticmachine @jughosta