[Discover] Fix flaky test for "context encoded URL params" #132808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jughosta
added
Feature:Discover
|
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
|
@elasticmachine merge upstream |
kertal
reviewed
May 25, 2022
Comment on lines
34
to
37
| await kibanaServer.uiSettings.update({ | ||
| 'doc_table:legacy': false, | ||
| 'discover:searchOnPageLoad': true, | ||
| }); |
There was a problem hiding this comment.
this is an interesting case since discover:searchOnPageLoad should already be true. I'd suggest to add to the after part of _search_on_page_load.ts
await kibanaServer.uiSettings.replace(defaultSettings);
So it should be cleaned up correctly , and since L34-L37 are setting default values, it could be removed.
|
@elasticmachine merge upstream |
kertal
approved these changes
May 25, 2022
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: cc @jughosta |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #132553
Flaky test runner 50x https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/667
Checklist