Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.17] remove human-readable automatic slug generation (#132593) #133093

Merged
merged 1 commit into from
May 30, 2022
Merged

[7.17] remove human-readable automatic slug generation (#132593) #133093

merged 1 commit into from
May 30, 2022
+11 −40

Conversation

vadimkibana
Copy link
Contributor

Backport

This will backport the following commits from main to 7.17:

Questions ?

Please refer to the Backport tool documentation

@vadimkibana @streamich
remove human-readable automatic slug generation (elastic#132593)
047c84f 
* remove human-readable automatic slug generation

* make change non-breaking

* [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix'

* remove test

Co-authored-by: streamich <streamich@gmail.com>
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit e857b30)

# Conflicts:
#	src/plugins/share/README.mdx
#	src/plugins/share/public/url_service/short_urls/short_url_client.test.ts
#	src/plugins/share/public/url_service/short_urls/short_url_client.ts
#	src/plugins/share/server/url_service/http/short_urls/register_create_route.ts
#	src/plugins/share/server/url_service/short_urls/short_url_client.ts
@vadimkibana vadimkibana enabled auto-merge (squash) May 30, 2022 08:40
@vadimkibana vadimkibana mentioned this pull request May 30, 2022
Merged
3 tasks
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] OSS Misc Functional Tests / kibana server with ssl redirects http requests at redirect port to https
  • [job] [logs] Default CI Group #4 / lens app lens drag and drop tests basic drag and drop should construct the basic split xy chart

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@vadimkibana vadimkibana merged commit 5995138 into elastic:7.17 May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vadimkibana @kibana-ci