Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Re-enable broken ML tests #133510

Merged
merged 1 commit into from
Jun 8, 2022
Merged

[Security Solution] Re-enable broken ML tests #133510

merged 1 commit into from
Jun 8, 2022

Conversation

xcrzx
Copy link
Contributor

@xcrzx xcrzx commented Jun 3, 2022 •
edited
Loading

Resolves: #128318

Summary

This PR unskips and updates tests that were disabled With the introduction of the V3 ML Modules (#131166):

Other changes

Migrated x-pack/test/detection_engine_api_integration/security_and_spaces/group1/create_ml.ts from @kbn/except to except - an assertion library used by Jest. That allowed us to remove irrelevant checks by using expect.objectContaining, hopefully reducing flakiness and simplifying test cases.

@xcrzx xcrzx force-pushed the re-enable-ml-tests branch 6 times, most recently from efeb5f7 to 431c046 Compare June 7, 2022 13:01
@xcrzx xcrzx added release_note:skip Skip the PR/issue when compiling release notes Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. auto-backport Deprecated - use backport:version if exact versions are needed Team:Detection Rule Management Security Detection Rule Management Team v8.3.0 v8.4.0 Feature:Detection Rules Security Solution rules and Detection Engine Feature:ML Rule Security Solution Machine Learning rule type labels Jun 7, 2022
@xcrzx xcrzx marked this pull request as ready for review June 7, 2022 14:57
@xcrzx xcrzx requested review from a team as code owners June 7, 2022 14:57
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@xcrzx xcrzx force-pushed the re-enable-ml-tests branch from 431c046 to 1801dfb Compare June 7, 2022 15:47
@xcrzx xcrzx self-assigned this Jun 7, 2022
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

  • 💛 Build #49575 was flaky 431c04659fca8abb2a76458fc0af7bcd002d589d
  • 💔 Build #49518 failed efeb5f7588159dec38d3259dc4d3b2634ca01be3
  • 💔 Build #49127 failed b3878f1b34e57f63cc13f0f9edd53f7b9e10828e
  • 💔 Build #49101 failed 88d7ecb735cc99b16ca0b4ad5f2d2e935d619817
  • 💔 Build #49073 failed 929ec31a927fa5540ed74038b9791e03233b55a3

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @xcrzx

@xcrzx xcrzx enabled auto-merge (squash) June 8, 2022 15:00
YulNaumenko
YulNaumenko approved these changes Jun 8, 2022
View reviewed changes
Copy link
Contributor

@YulNaumenko YulNaumenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xcrzx xcrzx merged commit 3eb00f5 into elastic:main Jun 8, 2022
kibanamachine pushed a commit that referenced this pull request Jun 8, 2022
@xcrzx
Re-enable brolen ML tests (#133510)
cdc300b 
(cherry picked from commit 3eb00f5)
@kibanamachine kibanamachine mentioned this pull request Jun 8, 2022
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.3

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

spong
spong reviewed Jun 8, 2022
View reviewed changes
Copy link
Member

@spong spong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code reviewed and LGTM! Thanks for pulling in expect and cleaning up the assertions over in the create_ml test as well!

kibanamachine added a commit that referenced this pull request Jun 8, 2022
@kibanamachine @xcrzx
Re-enable brolen ML tests (#133510) (#133903)
e734f48 
(cherry picked from commit 3eb00f5)

Co-authored-by: Dmitrii Shevchenko <dmitrii.shevchenko@elastic.co>
@xcrzx xcrzx deleted the re-enable-ml-tests branch June 9, 2022 08:54
@rylnd rylnd mentioned this pull request May 10, 2024
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spong spong spong left review comments

@YulNaumenko YulNaumenko YulNaumenko approved these changes

Assignees

@xcrzx xcrzx

Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Detection Rules Security Solution rules and Detection Engine Feature:ML Rule Security Solution Machine Learning rule type release_note:skip Skip the PR/issue when compiling release notes Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.3.0 v8.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Security Solution][Detections] Re-enable and fix broken ML tests as result of new V3 Modules
6 participants
@xcrzx @elasticmachine @kibana-ci @kibanamachine @spong @YulNaumenko