-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UI Framework] [K7] Add KuiToast and KuiGlobalToastList components. #13441
[UI Framework] [K7] Add KuiToast and KuiGlobalToastList components. #13441
Conversation
/** | ||
* Set scroll bar appearance on Chrome. | ||
*/ | ||
@mixin kuiScrollBar { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can use this in other places to give our scroll bars a consistent style.
Pretty rad. 😃 Some small stylistic notes, this top part I can clean up, so no worries, just explaining stuff I'd likely change when I go through after.
Functional stuff
Cool stuff duder. Gonna be a big change over the stuff that gets lost at the top of the page currently. |
Notes from design meeting....
|
looks great... would be also great to have a timed-out version of the notification (auto hide after X seconds)... would be interesting if we can utilize the coloured border line to indicate the timeliest (e.g. a "shrinking" line) |
6acd033
to
096f6e8
Compare
@uboness I like that idea too. I think something like that is communicated in the flat design file. I've run out of time on this PR so I'm going to merge now and we can circle back to that idea later. I'd also like to pause the timeout when the user mouses over the toast, but that'd require building an abstraction around |
…lastic#13441) * Fix bugs with KuiCallOut styles and update snapshots for KuiButton and KuiCallOut. * Add KuiToast. * Add KuiGlobalToastList. * Add stick-to-bottom behavior and transition-in animation. * Move transition animation from KuiToast to KuiGlobalToastList. * Support body-less KuiToasts. Fade them out when they're dismissed manually.
…lastic#13441) * Fix bugs with KuiCallOut styles and update snapshots for KuiButton and KuiCallOut. * Add KuiToast. * Add KuiGlobalToastList. * Add stick-to-bottom behavior and transition-in animation. * Move transition animation from KuiToast to KuiGlobalToastList. * Support body-less KuiToasts. Fade them out when they're dismissed manually.
…13441) * Fix bugs with KuiCallOut styles and update snapshots for KuiButton and KuiCallOut. * Add KuiToast. * Add KuiGlobalToastList. * Add stick-to-bottom behavior and transition-in animation. * Move transition animation from KuiToast to KuiGlobalToastList. * Support body-less KuiToasts. Fade them out when they're dismissed manually.
@snide I made a couple changes which deviate from the original design:
I moved the colored stripe to the top of the toast, so the status is more apparent. For taller toasts, this is especially helpful, because you can scan for good/bad/whatever toasts by the stripe, and then continue down to read the title and body.
I moved the toasts to the right side of the screen so they interfere less with the main content, especially navigation, which is generally on the left.
To-do: