Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UI Framework] Add KuiOutsideClickDetector #13521

Merged
merged 3 commits into from
Aug 21, 2017
Merged

[UI Framework] Add KuiOutsideClickDetector #13521

merged 3 commits into from
Aug 21, 2017

Conversation

cjcenizal
Copy link
Contributor

@cjcenizal cjcenizal commented Aug 15, 2017 •
edited
Loading

@cjcenizal cjcenizal added Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. v6.1.0 v7.0.0 labels Aug 15, 2017
stacey-gammon
stacey-gammon approved these changes Aug 21, 2017
View reviewed changes
Copy link
Contributor

@stacey-gammon stacey-gammon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, lgtm

zinckiwi
zinckiwi reviewed Aug 21, 2017
View reviewed changes
ui_framework/src/components/outside_click_detector/outside_click_detector.js Outdated
},
});

return cloneElement(this.props.children, props);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, sorry for missing the review request on this one. Looks good, though I think

return React.Children.only(this.props.children, child => cloneElement(child, props));

is still the best practice here (even if only for clearer error messaging to a future dev trying to use multiple children).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cjcenizal cjcenizal merged commit 45b10fb into elastic:master Aug 21, 2017
@cjcenizal cjcenizal deleted the feature/click-outside-detector branch August 21, 2017 15:59
cjcenizal added a commit to cjcenizal/kibana that referenced this pull request Aug 21, 2017
@cjcenizal
[UI Framework] Add KuiOutsideClickDetector (elastic#13521)
e43444a 
* Add KuiOutsideClickDetector.
* Convert KuiColorPicker and KuiPopover to use KuiOutsideClickDetector.
@cjcenizal cjcenizal mentioned this pull request Aug 21, 2017
Merged
cjcenizal added a commit that referenced this pull request Aug 21, 2017
@cjcenizal
[UI Framework] Add KuiOutsideClickDetector (#13521) (#13618)
e087c4b 
* Add KuiOutsideClickDetector.
* Convert KuiColorPicker and KuiPopover to use KuiOutsideClickDetector.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zinckiwi zinckiwi zinckiwi left review comments

@stacey-gammon stacey-gammon stacey-gammon approved these changes

Assignees
No one assigned
Labels
Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. v6.1.0 v7.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cjcenizal @zinckiwi @stacey-gammon