Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Step 1 ] VisEditors Telemetry enhancements (remove legacy agg-based telemetries) #135634

Merged
merged 6 commits into from
Jul 25, 2022
Merged

[Step 1 ] VisEditors Telemetry enhancements (remove legacy agg-based telemetries) #135634

merged 6 commits into from
Jul 25, 2022

Conversation

alexwizp
Copy link
Contributor

@alexwizp alexwizp commented Jul 4, 2022 •
edited
Loading

Closes: #117367
Part of #132396

Summary:
Remove all existing telemetries from agg-based visualizations

@alexwizp alexwizp force-pushed the relementy_agg_based_remove branch from 211c71e to 9101d05 Compare July 4, 2022 11:26
@alexwizp alexwizp marked this pull request as ready for review July 4, 2022 14:12
@alexwizp alexwizp requested review from a team as code owners July 4, 2022 14:12
@alexwizp alexwizp added v8.4.0 Feature:Telemetry release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Jul 4, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

@alexwizp alexwizp self-assigned this Jul 4, 2022
afharo
afharo approved these changes Jul 5, 2022
View reviewed changes
Copy link
Member

@afharo afharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@flash1293
Copy link
Contributor

Looks good, but let's not merge this until we are 100% sure we will get the new telemetry in in the same release.

@afharo afharo mentioned this pull request Jul 5, 2022
Closed
@alexwizp
Copy link
Contributor Author

@elasticmachine merge upstream

@TinaHeiligers
Copy link
Contributor

@elasticmachine merge upstream

@alexwizp
Copy link
Contributor Author

@elasticmachine merge upstream

flash1293
flash1293 approved these changes Jul 22, 2022
View reviewed changes
Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's wait with the merge though until the ui counter PR is ready

@alexwizp
Copy link
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
visTypePie 9.0KB 8.7KB -319.0B
visTypeXy 60.4KB 60.2KB -178.0B
visualizations 237.5KB 237.0KB -469.0B
total -966.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
visTypeHeatmap 10.2KB 10.0KB -151.0B
visTypePie 7.7KB 7.5KB -203.0B
visTypeXy 43.4KB 43.1KB -244.0B
visualizations 47.0KB 46.8KB -240.0B
total -838.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
visualizations 16 15 -1

Total ESLint disabled count

id before after diff
visualizations 18 17 -1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @alexwizp

@alexwizp alexwizp merged commit ded1fcb into elastic:main Jul 25, 2022
@alexwizp alexwizp mentioned this pull request Sep 8, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afharo afharo afharo approved these changes

@flash1293 flash1293 flash1293 approved these changes

Assignees

@alexwizp alexwizp

Labels
backport:skip This commit does not require backporting Feature:Telemetry release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Visualization collectors iterate over all visualizations 4 times
7 participants
@alexwizp @elasticmachine @flash1293 @TinaHeiligers @kibana-ci @afharo @kibanamachine