Refetch even when the query has not changed

[lukasolson]

Fixes #13743.

This PR makes it so any time a query is submitted (in Discover/Visualize/Dashboard), a fetch happens, even if the query itself doesn't change.

[Bargs]

LGTM. Just left one minor suggestion about function names.

[Bargs]

I called these methods updateQuery since they only update state. Now that they also fetch results, maybe we should call them something like fetchWithQuery?

[lukasolson]

👍 9c27c33

[Bargs]

That name sounds good to me! Did you forget to update all the usages though?

[lukasolson]

How embarrassing. ef09fa0

[weltenwort]

It seems to fix the issue, but leads to updateQueryAndFetch being called twice when the query has changed: once for the "submit" and once triggered by the $watch('state.query', ...). Is there maybe some way to get rid of that $watch?

[Bargs]

For background, the watch is there in order to ensure old queries get migrated. Queries on saved searches get migrated at load time, but a query might also be stored in appstate in the url of a bookmark or link. It was the only thing I could think of to ensure the app is always working with an updated query object.

[lukasolson]

@weltenwort Invoking the function multiple times doesn't result in multiple HTTP requests, because of how the courier works. That being said, I agree there is a bit of code smell there, but the only thing I can think of to prevent this would be to manually check if the query object has changed and return early if it has (since it will be called inside the watch). Thoughts?

[weltenwort]

After thinking some more about it I can't think of an elegant fix either. Relying on the deduplication feature of courier is probably the way to go here.

[lukasolson]

6.x (6.1.0): eb86cff
6.0 (6.0.0): 0151396