-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TSVB] Adding check for model and visData #13854
Conversation
this is the PR that broke this: #13742
however in the editor example it goes a bit differently:
in this PR #13779 tsvb editor sets the vis.initialized in its constructor. now the race condition starts.
i think this should be fixed on visualize side. editors render method (the first time, without data) should not be called if editor set the vis.initialized in constructor (which means request to backend is pending) pr to do that: #13858 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but maybe its not needed after we address the issue in visualize
it's probably not as necessary but I think it's good to have these checks. |
This PR adds a check for the
model
andvisData
properties. These two values should essentially never be null. Due to a recent PR there is now a race condition which requires us to check to make sure these values are valid before rendering the rest of the React tree.