Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow panning beyond dateline #13955

Merged

Conversation

thomasneirynck
Copy link
Contributor

@thomasneirynck thomasneirynck commented Sep 12, 2017

Summary: Users can now pan and zoom the map beyond the date line.

Closes #13874.

@thomasneirynck thomasneirynck added Feature:Visualizations Generic visualization features (in case no more specific feature label is available) release_note:fix review v6.0.0-rc1 v6.1.0 v7.0.0 labels Sep 12, 2017
@ppisljar
Copy link
Member

jenkins, test this

@ppisljar
Copy link
Member

seems some tests are failling due to this change

@thomasneirynck
Copy link
Contributor Author

The test failed because now zooming and panning doesnt snap the map to be inside the dateline. I changed the reference data so that it now matches the new behavior.

Copy link
Member

@ppisljar ppisljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@nreese nreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomasneirynck thomasneirynck merged commit e8b43b5 into elastic:master Sep 18, 2017
thomasneirynck added a commit to thomasneirynck/kibana that referenced this pull request Sep 18, 2017
@thomasneirynck
Copy link
Contributor Author

Backports:
6.x: #14038
6.0: #14039

@marius-dr
Copy link
Member

@thomasneirynck Looks like the backport to 6.0 is still open and needs to be merged.

@thomasneirynck
Copy link
Contributor Author

thanks @marius-dr for the reminder

@AntoineAndElastic
Copy link

AntoineAndElastic commented Nov 1, 2018

When panning accross the dateline there is no data anymore. Is there a setting in Kibana or Elastic to allow seeing data when crossing the dateline?
image

@thomasneirynck
Copy link
Contributor Author

@AntoineAndElastic this is a limitation of Leaflet. We are working on a new plugin for Kibana, using MapboxGL, which does not have that limitation. For details, see #19582

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Visualizations Generic visualization features (in case no more specific feature label is available) release_note:fix review v6.0.0 v6.1.0 v7.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants