[Infra Monitoring UI] Change infrastructure pages titles to use breadcrumbs #135874 #140824
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| /* | ||
| * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
| * or more contributor license agreements. Licensed under the Elastic License | ||
| * 2.0; you may not use this file except in compliance with the Elastic License | ||
| * 2.0. | ||
| */ | ||
|
|
||
| import { ChromeBreadcrumb } from '@kbn/core/public'; | ||
| import { useEffect } from 'react'; | ||
| import { observabilityTitle } from '../translations'; | ||
| import { useKibanaContextForPlugin } from './use_kibana'; | ||
|
|
||
| export const useDocumentTitle = (extraTitles: ChromeBreadcrumb[]) => { | ||
| const { | ||
| services: { chrome }, | ||
| } = useKibanaContextForPlugin(); | ||
|
|
||
| useEffect(() => { | ||
| const docTitle = [{ text: observabilityTitle }, ...extraTitles] | ||
| .reverse() | ||
| .map((breadcrumb) => breadcrumb.text as string); | ||
|
|
||
| chrome.docTitle.change(docTitle); | ||
| }, [chrome, extraTitles]); | ||
| }; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| /* | ||
| * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
| * or more contributor license agreements. Licensed under the Elastic License | ||
| * 2.0; you may not use this file except in compliance with the Elastic License | ||
| * 2.0. | ||
| */ | ||
|
|
||
| import React from 'react'; | ||
| import { mount } from 'enzyme'; | ||
| import { PageError } from './page_error'; | ||
| import { errorTitle } from '../../../../translations'; | ||
| import { InfraHttpError } from '../../../../types'; | ||
| import { useDocumentTitle } from '../../../../hooks/use_document_title'; | ||
| import { I18nProvider } from '@kbn/i18n-react'; | ||
|
|
||
| jest.mock('../../../../hooks/use_document_title', () => ({ | ||
| useDocumentTitle: jest.fn(), | ||
| })); | ||
|
|
||
| describe('PageError component', () => { | ||
| const mountError = (name: string, error: InfraHttpError) => | ||
| mount( | ||
| <I18nProvider> | ||
| <PageError name={name} error={error} /> | ||
| </I18nProvider> | ||
| ).find('PageError'); | ||
|
|
||
| it('renders correctly and set title', () => { | ||
| const mounted = mountError('test', { | ||
| body: { | ||
| statusCode: 500, | ||
| message: 'Error Message', | ||
| }, | ||
| message: 'Error Message', | ||
| } as InfraHttpError); | ||
|
|
||
| const callOut = mounted.find('EuiCallOut'); | ||
| expect(callOut.render()).toMatchSnapshot(); | ||
|
There was a problem hiding this comment. Instead of matching a snapshot, how about if we just assert the existence of the "Please click the back button and try again." on the page? There was a problem hiding this comment. I removed the snapshot and I added a check for the error name and message |
||
|
|
||
| expect(useDocumentTitle).toHaveBeenCalledWith([{ text: `${errorTitle}` }]); | ||
| }); | ||
| }); | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -6,30 +6,22 @@ | |
| */ | ||
|
|
||
| import React from 'react'; | ||
| import { useDocumentTitle } from '../../../../hooks/use_document_title'; | ||
| import { InvalidNodeError } from './invalid_node'; | ||
| import { ErrorPageBody } from '../../../error'; | ||
| import { InfraHttpError } from '../../../../types'; | ||
| import { errorTitle } from '../../../../translations'; | ||
|
|
||
| interface Props { | ||
| name: string; | ||
| error: InfraHttpError; | ||
| } | ||
|
|
||
| export const PageError = ({ error, name }: Props) => { | ||
|
There was a problem hiding this comment. It would be nice to add a test for this one! There was a problem hiding this comment. I added one unit test for the error page component and a functional test 4e2fd39 |
||
| useDocumentTitle([{ text: errorTitle }]); | ||
|
|
||
| return ( | ||
| <> | ||
| {error.body?.statusCode === 404 ? ( | ||
| <InvalidNodeError nodeName={name} /> | ||
| ) : ( | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Enzyme works just fine, especially if we need to play with component internals and state. In this case we don't need to do that so I believe we could use react-testing-library. What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a good point, thank you. I agree, I realize that we don't actually need to change the internal state there - just to test if the hook is called and the text error message is correct. I updated it 👍