Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Graph] Fix query bar autocomplete #140963

Merged
merged 5 commits into from
Sep 22, 2022

Conversation

jughosta
Copy link
Contributor

@jughosta jughosta commented Sep 19, 2022

Closes #139246

Summary

This PR makes sure that query bar does not filter suggestions by the global time range.

Sep-21-2022 17-19-07

It was possible to reproduce by setting an older time range in Discover and going to Graph page. Try searching for a field like extension.keyword : <suggestion list should appear here>.

@jughosta jughosta added Feature:Discover Discover Application release_note:fix Feature:Graph Graph application feature backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Sep 19, 2022
@jughosta jughosta self-assigned this Sep 19, 2022
@jughosta jughosta changed the title [Graph] Fix unified search autocomplete [Graph] Fix unified search dependency issue which breaks autocomplete Sep 19, 2022
@jughosta jughosta changed the title [Graph] Fix unified search dependency issue which breaks autocomplete [Graph] Fix unified search autocomplete Sep 19, 2022
@alexwizp
Copy link
Contributor

@jughosta please wait for #140880 . We wanna fix that component to avoid similar issues in future

@jughosta jughosta changed the title [Graph] Fix unified search autocomplete [Graph] Fix query bar autocomplete Sep 21, 2022
@jughosta jughosta marked this pull request as ready for review September 21, 2022 16:19
@jughosta
Copy link
Contributor Author

@elasticmachine merge upstream

@jughosta jughosta requested a review from a team as a code owner September 21, 2022 16:19
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-graph (Feature:Graph)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
graph 450.3KB 450.4KB +35.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jughosta

Copy link
Member

@kertal kertal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Tested locally, works as expected, no more time range filter in the request! Thank you 🙏

@jughosta jughosta merged commit 03a3446 into elastic:main Sep 22, 2022
@jughosta jughosta deleted the 139246-graph-autocomplete branch September 22, 2022 11:04
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Sep 22, 2022
* [Graph] Fix unified search dep

* [Graph] Fix after the merge

* [Graph] Fix autocomplete by excluding filtering by time range

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 03a3446)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.5

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Sep 22, 2022
* [Graph] Fix unified search dep

* [Graph] Fix after the merge

* [Graph] Fix autocomplete by excluding filtering by time range

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 03a3446)

Co-authored-by: Julia Rechkunova <julia.rechkunova@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) Feature:Discover Discover Application Feature:Graph Graph application feature release_note:fix v8.5.0 v8.6.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auto-complete doesn't work in graph query bar when the data is old (Last 15 years)
6 participants