-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Graph] Fix query bar autocomplete #140963
Conversation
@elasticmachine merge upstream |
Pinging @elastic/kibana-graph (Feature:Graph) |
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @jughosta |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 Tested locally, works as expected, no more time range filter in the request! Thank you 🙏
* [Graph] Fix unified search dep * [Graph] Fix after the merge * [Graph] Fix autocomplete by excluding filtering by time range Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 03a3446)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
* [Graph] Fix unified search dep * [Graph] Fix after the merge * [Graph] Fix autocomplete by excluding filtering by time range Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 03a3446) Co-authored-by: Julia Rechkunova <julia.rechkunova@elastic.co>
Closes #139246
Summary
This PR makes sure that query bar does not filter suggestions by the global time range.
It was possible to reproduce by setting an older time range in Discover and going to Graph page. Try searching for a field like
extension.keyword : <suggestion list should appear here>
.