Deprecate expression based scripted fields #14281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bargs
force-pushed
the
deprecateExpressions
branch
from
205fc05 to
8f54824
Compare
Bargs
force-pushed
the
deprecateExpressions
branch
from
35fd977 to
5bd280e
Compare
bmcconaghy
approved these changes
Nov 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14214
Related #14310
This PR adds deprecation messages in two places in the Kibana UI. The first is the scripted field creation page, where a message is shown if you've chosen a deprecated language for your script. The second is the index pattern scripted field list page, where a message is shown if any existing scripted fields use a deprecated language. It also adds an error message to the list page if a completely unsupported language is detected.
Scripted field creation page
Scripted field list page
Completely unsupported language detected
