Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[unified search] Query string input uses data views plugin directly instead of via deprecated data plugin reference #143611

Merged
merged 10 commits into from
Oct 20, 2022
Merged

[unified search] Query string input uses data views plugin directly instead of via deprecated data plugin reference #143611

merged 10 commits into from
Oct 20, 2022

Conversation

mattkime
Copy link
Contributor

@mattkime mattkime commented Oct 19, 2022 •
edited
Loading

Summary

Tech debt refactor. Query string input now requires the data views plugin to be passed directly instead of referencing it via the deprecated data plugin reference. Query string input consumers have been updated as well.

@mattkime mattkime changed the title use data views plugin [unified search] Query string input uses data views plugin directly instead of via deprecated data plugin reference Oct 19, 2022
@mattkime mattkime added v8.6.0 Feature:Data Views Data Views code and UI - index patterns before 8.0 Feature:Unified search Unified search related tasks release_note:skip Skip the PR/issue when compiling release notes labels Oct 19, 2022
@mattkime mattkime marked this pull request as ready for review October 19, 2022 16:01
@mattkime mattkime requested review from a team as code owners October 19, 2022 16:01
davismcphee
davismcphee approved these changes Oct 19, 2022
View reviewed changes
Copy link
Contributor

@davismcphee davismcphee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Graph change LGTM

@botelastic botelastic bot added Team:APM All issues that need APM UI Team support Team:Fleet Team label for Observability Data Collection Fleet team Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability labels Oct 19, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:APM)

@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

nickpeihl
nickpeihl approved these changes Oct 19, 2022
View reviewed changes
Copy link
Member

@nickpeihl nickpeihl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kibana-gis changes lgtm!

code review

matschaffer
matschaffer approved these changes Oct 20, 2022
View reviewed changes
Copy link
Contributor

@matschaffer matschaffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@elastic/infra-monitoring-ui changes look good

jgowdyelastic
jgowdyelastic approved these changes Oct 20, 2022
View reviewed changes
Copy link
Member

@jgowdyelastic jgowdyelastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ML and Transforms changes LGTM

Dosant
Dosant approved these changes Oct 20, 2022
View reviewed changes
Copy link
Contributor

@Dosant Dosant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

App services lgtm

dej611
dej611 approved these changes Oct 20, 2022
View reviewed changes
Copy link
Contributor

@dej611 dej611 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@elastic/kibana-vis-editors changes 👍

juliaElastic
juliaElastic approved these changes Oct 20, 2022
View reviewed changes
Copy link
Contributor

@juliaElastic juliaElastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fleet change LGTM

gbamparop
gbamparop approved these changes Oct 20, 2022
View reviewed changes
Copy link
Contributor

@gbamparop gbamparop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APM changes LGTM!

@mattkime mattkime requested a review from a team as a code owner October 20, 2022 13:03
@mattkime mattkime enabled auto-merge (squash) October 20, 2022 13:03
flash1293
flash1293 approved these changes Oct 20, 2022
View reviewed changes
Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested and works, LGTM

ymao1
ymao1 approved these changes Oct 20, 2022
View reviewed changes
Copy link
Contributor

@ymao1 ymao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Response ops changes LGTM. Code review only.

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 3.1MB 3.1MB +24.0B
fleet 916.7KB 916.7KB +48.0B
graph 454.5KB 454.5KB +24.0B
infra 1.0MB 1.0MB +24.0B
lens 1.3MB 1.3MB +24.0B
ml 3.4MB 3.4MB +48.0B
stackAlerts 73.9KB 73.9KB +36.0B
synthetics 1.0MB 1.0MB +48.0B
transform 388.9KB 388.9KB +48.0B
unifiedSearch 262.1KB 262.1KB +25.0B
visDefaultEditor 142.3KB 142.3KB +24.0B
visTypeTimeseries 503.5KB 503.5KB +12.0B
total +385.0B
Unknown metric groups

References to deprecated APIs

id before after diff
unifiedSearch 24 23 -1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mattkime mattkime merged commit 631c24a into elastic:main Oct 20, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Oct 20, 2022
@juliaElastic juliaElastic mentioned this pull request Nov 2, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliaElastic juliaElastic juliaElastic approved these changes

@davismcphee davismcphee davismcphee approved these changes

@jgowdyelastic jgowdyelastic jgowdyelastic approved these changes

@ymao1 ymao1 ymao1 approved these changes

@Dosant Dosant Dosant approved these changes

@gbamparop gbamparop gbamparop approved these changes

@shahzad31 shahzad31 shahzad31 approved these changes

@nickpeihl nickpeihl nickpeihl approved these changes

@flash1293 flash1293 flash1293 approved these changes

@dej611 dej611 dej611 approved these changes

@matschaffer matschaffer matschaffer approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting Feature:Data Views Data Views code and UI - index patterns before 8.0 Feature:Unified search Unified search related tasks release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support Team:Fleet Team label for Observability Data Collection Fleet team Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v8.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.