Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move appservices plugins to visualizations team #144991

Merged
merged 3 commits into from
Nov 14, 2022
Merged

Move appservices plugins to visualizations team #144991

merged 3 commits into from
Nov 14, 2022

Conversation

stratoula
Copy link
Contributor

@stratoula stratoula commented Nov 10, 2022 •
edited
Loading

Summary

Moves the ownership for some of the appservices code to the visualizations team:

  • expressions plugin
  • unified search
  • data plugin, we decided for now to co-own it with the @elastic/kibana-data-discovery team

@stratoula stratoula added Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.6.0 backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes labels Nov 10, 2022
@stratoula stratoula marked this pull request as ready for review November 10, 2022 16:43
@stratoula stratoula requested a review from a team as a code owner November 10, 2022 16:43
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations @elastic/kibana-visualizations-external (Team:Visualizations)

@botelastic botelastic bot added the Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) label Nov 10, 2022
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

ESLint disabled in files

id before after diff
osquery 1 2 +1

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
fleet 59 65 +6
osquery 108 113 +5
securitySolution 441 447 +6
total +19

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
fleet 67 73 +6
osquery 109 115 +6
securitySolution 518 524 +6
total +20

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

kertal
kertal approved these changes Nov 14, 2022
View reviewed changes
Copy link
Member

@kertal kertal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stratoula stratoula merged commit 4a4bc55 into elastic:main Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickofthyme nickofthyme nickofthyme approved these changes

@jloleysens jloleysens jloleysens approved these changes

@kertal kertal kertal approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@stratoula @elasticmachine @kibana-ci @kertal @jloleysens @nickofthyme