Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Fixes #144669: Incorrect “Learn more” link #145077

Merged
merged 1 commit into from
Nov 14, 2022
Merged

[APM] Fixes #144669: Incorrect “Learn more” link #145077

merged 1 commit into from
Nov 14, 2022

Conversation

sorenlouv
Copy link
Member

@sorenlouv sorenlouv commented Nov 14, 2022 •
edited by kibanamachine
Loading

Fixes #144669

@sorenlouv sorenlouv requested a review from a team as a code owner November 14, 2022 09:31
@botelastic botelastic bot added the Team:APM All issues that need APM UI Team support label Nov 14, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:APM)

@sorenlouv sorenlouv added backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support and removed Team:APM All issues that need APM UI Team support labels Nov 14, 2022
kpatticha
kpatticha approved these changes Nov 14, 2022
View reviewed changes
Copy link
Contributor

@kpatticha kpatticha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing it. it's weird though why elastic.co didn't redirect to guide

@sorenlouv sorenlouv enabled auto-merge (squash) November 14, 2022 10:03
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

ESLint disabled in files

id before after diff
osquery 1 2 +1

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
fleet 59 65 +6
osquery 108 113 +5
securitySolution 441 447 +6
total +19

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
fleet 67 73 +6
osquery 109 115 +6
securitySolution 518 524 +6
total +20

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@sorenlouv sorenlouv merged commit f893523 into elastic:main Nov 14, 2022
@kibanamachine kibanamachine mentioned this pull request Nov 14, 2022
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 14, 2022
@sorenlouv
[APM] Fixes elastic#144669: Incorrect “Learn more” link (elastic#145077)
d53a688 
Fixes elastic#144669

(cherry picked from commit f893523)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.5

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Nov 14, 2022
@kibanamachine @sorenlouv
[8.5] [APM] Fixes #144669: Incorrect “Learn more” link (#145077) (#14…
a20e50e 
…5087)

# Backport

This will backport the following commits from `main` to `8.5`:
- [[APM] Fixes #144669: Incorrect “Learn more” link
(#145077)](#145077)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Søren
Louv-Jansen","email":"soren.louv@elastic.co"},"sourceCommit":{"committedDate":"2022-11-14T10:31:45Z","message":"[APM]
Fixes #144669: Incorrect “Learn more” link (#145077)\n\nFixes
https://github.com/elastic/kibana/issues/144669","sha":"f893523d63e99d623269969af3f611ddff36c1c1","branchLabelMapping":{"^v8.6.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:APM","release_note:skip","backport:prev-minor","v8.6.0"],"number":145077,"url":"https://github.com/elastic/kibana/pull/145077","mergeCommit":{"message":"[APM]
Fixes #144669: Incorrect “Learn more” link (#145077)\n\nFixes
https://github.com/elastic/kibana/issues/144669","sha":"f893523d63e99d623269969af3f611ddff36c1c1"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.6.0","labelRegex":"^v8.6.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/145077","number":145077,"mergeCommit":{"message":"[APM]
Fixes #144669: Incorrect “Learn more” link (#145077)\n\nFixes
https://github.com/elastic/kibana/issues/144669","sha":"f893523d63e99d623269969af3f611ddff36c1c1"}}]}]
BACKPORT-->

Co-authored-by: Søren Louv-Jansen <soren.louv@elastic.co>
@mistic
Copy link
Member

mistic commented Nov 16, 2022

Changing v8.5.1 label into v8.5.2 as this PR didn't make into the build candidate.

@mistic mistic added v8.5.2 and removed v8.5.1 labels Nov 16, 2022
@sorenlouv sorenlouv deleted the fix-issue-144669 branch April 12, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kpatticha kpatticha kpatticha approved these changes

Assignees
No one assigned
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support v8.5.2 v8.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Learn more" on Integrations > APM page links out to 404 error
6 participants
@sorenlouv @elasticmachine @kibana-ci @kibanamachine @mistic @kpatticha