[Stack Monitoring] api tests for cluster and elasticsearch #145138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klacabane
added
the
Team:Infra Monitoring UI - DEPRECATED
klacabane
commented
Nov 14, 2022
| @@ -6,8 +6,10 @@ | |||
| */ | |||
|
|
|||
| import { get, groupBy } from 'lodash'; | |||
| import { prefixIndexPatternWithCcs } from '../../../../../common/ccs_utils'; | |||
| import { INDEX_PATTERN_ELASTICSEARCH } from '../../../../../common/constants'; | |||
| import { | |||
There was a problem hiding this comment.
We didn't read from agent data in this query. Uncovered this with failing tests
…-ref HEAD~1..HEAD --fix'
klacabane
commented
Nov 15, 2022
| }); | ||
| }); | ||
|
|
||
| describe('with red platinum cluster', () => { |
There was a problem hiding this comment.
These tests are duplicates of the legacy ones that are not testing metricbeat data. I've attempted to use the corresponding _mb archive to no avail so we have to rewrite if we want to keep them.
I've opted to remove them without replacement because they're only testing variants of the same API, and the first test guarantees that metricbeat/package data is properly loaded
|
Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI) |
klacabane
added
the
release_note:skip
|
@elasticmachine merge upstream |
| describe('node detail - metricbeat and package', function () { | ||
| ['mb', 'package'].forEach((source) => { | ||
| describe(`node detail ${source}`, function () { | ||
| // TODO: https://github.com/elastic/stack-monitoring/issues/31 |
There was a problem hiding this comment.
this almost 4 years old 🎂
There was a problem hiding this comment.
Let's add that to the board :)
crespocarlos
approved these changes
Nov 21, 2022
| }); | ||
| }); | ||
|
|
||
| describe('with red platinum cluster', () => { |
There was a problem hiding this comment.
We don't need these red platinum and shards relocating tests anymore?
There was a problem hiding this comment.
There was a problem hiding this comment.
Just realized it's a different file but the comment applies for this one as well
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Unknown metric groupsESLint disabled in files
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @klacabane |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 22, 2022
…45138) ### Summary Part of elastic#119658 Add api integration tests for cluster and elasticsearch routes to validate behavior when reading data ingested by elastic-agent. We currently have a testing suite for legacy and another one for metricbeat. Since metricbeat and agent documents only differ in their metadata, for example agent will populate a `data_stream.*` property to identify the document types while metricbeat uses `metricset.*`, the tests assertion validating _business_ data should pass regardless of the documents source. With this in mind the metricbeat tests were updated to run the tests twice, one time with metricbeat data and a second time with package data. To generate the archives the `metrics-*` mappings were extracted with esArchiver from an elasticsearch with the package installed, and the documents were transformed from the metricbeat documents with [this script](https://gist.github.com/klacabane/654497ff86053c60af6df15fa6f6f657). Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 5cf0d0f)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Nov 22, 2022
…5138) (#145985) # Backport This will backport the following commits from `main` to `8.6`: - [[Stack Monitoring] api tests for cluster and elasticsearch (#145138)](#145138) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Kevin Lacabane","email":"kevin.lacabane@elastic.co"},"sourceCommit":{"committedDate":"2022-11-22T13:02:50Z","message":"[Stack Monitoring] api tests for cluster and elasticsearch (#145138)\n\n### Summary\r\nPart of https://github.com/elastic/kibana/issues/119658\r\n\r\nAdd api integration tests for cluster and elasticsearch routes to\r\nvalidate behavior when reading data ingested by elastic-agent.\r\n\r\nWe currently have a testing suite for legacy and another one for\r\nmetricbeat. Since metricbeat and agent documents only differ in their\r\nmetadata, for example agent will populate a `data_stream.*` property to\r\nidentify the document types while metricbeat uses `metricset.*`, the\r\ntests assertion validating _business_ data should pass regardless of the\r\ndocuments source. With this in mind the metricbeat tests were updated to\r\nrun the tests twice, one time with metricbeat data and a second time\r\nwith package data.\r\n\r\nTo generate the archives the `metrics-*` mappings were extracted with\r\nesArchiver from an elasticsearch with the package installed, and the\r\ndocuments were transformed from the metricbeat documents with [this\r\nscript](https://gist.github.com/klacabane/654497ff86053c60af6df15fa6f6f657).\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"5cf0d0f24817db4b36501c6c06f6cfb4cd61c296","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Infra Monitoring UI","release_note:skip","Feature:Stack Monitoring","v8.6.0","v8.7.0"],"number":145138,"url":"https://github.com/elastic/kibana/pull/145138","mergeCommit":{"message":"[Stack Monitoring] api tests for cluster and elasticsearch (#145138)\n\n### Summary\r\nPart of https://github.com/elastic/kibana/issues/119658\r\n\r\nAdd api integration tests for cluster and elasticsearch routes to\r\nvalidate behavior when reading data ingested by elastic-agent.\r\n\r\nWe currently have a testing suite for legacy and another one for\r\nmetricbeat. Since metricbeat and agent documents only differ in their\r\nmetadata, for example agent will populate a `data_stream.*` property to\r\nidentify the document types while metricbeat uses `metricset.*`, the\r\ntests assertion validating _business_ data should pass regardless of the\r\ndocuments source. With this in mind the metricbeat tests were updated to\r\nrun the tests twice, one time with metricbeat data and a second time\r\nwith package data.\r\n\r\nTo generate the archives the `metrics-*` mappings were extracted with\r\nesArchiver from an elasticsearch with the package installed, and the\r\ndocuments were transformed from the metricbeat documents with [this\r\nscript](https://gist.github.com/klacabane/654497ff86053c60af6df15fa6f6f657).\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"5cf0d0f24817db4b36501c6c06f6cfb4cd61c296"}},"sourceBranch":"main","suggestedTargetBranches":["8.6"],"targetPullRequestStates":[{"branch":"8.6","label":"v8.6.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/145138","number":145138,"mergeCommit":{"message":"[Stack Monitoring] api tests for cluster and elasticsearch (#145138)\n\n### Summary\r\nPart of https://github.com/elastic/kibana/issues/119658\r\n\r\nAdd api integration tests for cluster and elasticsearch routes to\r\nvalidate behavior when reading data ingested by elastic-agent.\r\n\r\nWe currently have a testing suite for legacy and another one for\r\nmetricbeat. Since metricbeat and agent documents only differ in their\r\nmetadata, for example agent will populate a `data_stream.*` property to\r\nidentify the document types while metricbeat uses `metricset.*`, the\r\ntests assertion validating _business_ data should pass regardless of the\r\ndocuments source. With this in mind the metricbeat tests were updated to\r\nrun the tests twice, one time with metricbeat data and a second time\r\nwith package data.\r\n\r\nTo generate the archives the `metrics-*` mappings were extracted with\r\nesArchiver from an elasticsearch with the package installed, and the\r\ndocuments were transformed from the metricbeat documents with [this\r\nscript](https://gist.github.com/klacabane/654497ff86053c60af6df15fa6f6f657).\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"5cf0d0f24817db4b36501c6c06f6cfb4cd61c296"}}]}] BACKPORT--> Co-authored-by: Kevin Lacabane <kevin.lacabane@elastic.co>
This was referenced Nov 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part of #119658
Add api integration tests for cluster and elasticsearch routes to validate behavior when reading data ingested by elastic-agent.
We currently have a testing suite for legacy and another one for metricbeat. Since metricbeat and agent documents only differ in their metadata, for example agent will populate a
data_stream.*property to identify the document types while metricbeat usesmetricset.*, the tests assertion validating business data should pass regardless of the documents source. With this in mind the metricbeat tests were updated to run the tests twice, one time with metricbeat data and a second time with package data.To generate the archives the
metrics-*mappings were extracted with esArchiver from an elasticsearch with the package installed, and the documents were transformed from the metricbeat documents with this script.