Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fleet] Fix import causing linter errors #145394

Merged
merged 3 commits into from
Nov 16, 2022
Merged

[Fleet] Fix import causing linter errors #145394

merged 3 commits into from
Nov 16, 2022

Conversation

criamico
Copy link
Contributor

@criamico criamico commented Nov 16, 2022 •
edited by kibanamachine
Loading

Summary

Fixing an import in the wrong order that was causing multiple PRs to have linter error and pinging Fleet.

@criamico criamico added release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team skip-ci v8.7.0 labels Nov 16, 2022
@criamico criamico self-assigned this Nov 16, 2022
@criamico criamico requested a review from a team as a code owner November 16, 2022 15:47
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@criamico
Copy link
Contributor Author

@elasticmachine merge upstream

@criamico
Copy link
Contributor Author

@elasticmachine merge upstream

@spalger spalger merged commit 6cd5d3d into elastic:main Nov 16, 2022
@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
❌ 8.7 The branch "8.7" does not exist

Manual backport

To create the backport manually run:

node scripts/backport --pr 145394

Questions ?

Please refer to the Backport tool documentation

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Nov 18, 2022
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 145394 locally

@criamico criamico added the backport:skip This commit does not require backporting label Nov 18, 2022
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Nov 18, 2022
@criamico criamico removed the v8.6.0 label Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nchaulet nchaulet nchaulet approved these changes

Assignees

@criamico criamico

Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes skip-ci Team:Fleet Team label for Observability Data Collection Fleet team v8.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@criamico @elasticmachine @kibanamachine @nchaulet @spalger