Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOCS] Adds the 8.6 Presentation docs #145474

Merged
merged 5 commits into from
Nov 28, 2022
Merged

[DOCS] Adds the 8.6 Presentation docs #145474

merged 5 commits into from
Nov 28, 2022

Conversation

KOTungseth
Copy link
Contributor

@KOTungseth KOTungseth commented Nov 16, 2022 •
edited by kibanamachine
Loading

@KOTungseth KOTungseth added Team:Docs Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas release_note:skip Skip the PR/issue when compiling release notes v8.6.0 v8.7.0 labels Nov 16, 2022
@KOTungseth KOTungseth self-assigned this Nov 16, 2022
@github-actions
Copy link
Contributor

Documentation preview:

@KOTungseth
Copy link
Contributor Author

@elasticmachine run elasticsearch-ci/docs

@KOTungseth KOTungseth marked this pull request as ready for review November 17, 2022 17:05
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-docs (Team:Docs)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

Heenawter
Heenawter reviewed Nov 17, 2022
View reviewed changes
Copy link
Contributor

@Heenawter Heenawter left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only skimmed the Canvas Docs changes, but they look good from my perspective since it was just wording changes and not actually changes to content.

Left a few comments about the new options list additional settings - plus, not sure if we should update this options list screenshot to include the Include/Exclude toggle and Exists query to keep it up to date?

image

docs/user/dashboard/make-dashboards-interactive.asciidoc Outdated Show resolved Hide resolved
docs/user/dashboard/make-dashboards-interactive.asciidoc Outdated Show resolved Hide resolved
gchaps
gchaps approved these changes Nov 17, 2022
View reviewed changes
Copy link
Contributor

@gchaps gchaps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a few minor comments.

docs/canvas/canvas-tutorial.asciidoc Outdated Show resolved Hide resolved
docs/canvas/canvas-tutorial.asciidoc Outdated Show resolved Hide resolved
docs/user/canvas.asciidoc Show resolved Hide resolved
docs/user/canvas.asciidoc Outdated Show resolved Hide resolved
docs/user/dashboard/make-dashboards-interactive.asciidoc Outdated Show resolved Hide resolved
KOTungseth and others added 2 commits November 28, 2022 09:23
@KOTungseth @gchaps
Update docs/user/canvas.asciidoc
77b2937 
Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
@KOTungseth
Review comments
7f9e085
@KOTungseth KOTungseth enabled auto-merge (squash) November 28, 2022 16:09
@KOTungseth KOTungseth merged commit 9a26af6 into elastic:main Nov 28, 2022
@kibanamachine kibanamachine mentioned this pull request Nov 28, 2022
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 28, 2022
@KOTungseth
[DOCS] Adds the 8.6 Presentation docs (elastic#145474)
a3cfcbd 
## Summary

Adds the docs for the following:

- elastic#141824
Doc preview:
https://kibana_145474.docs-preview.app.elstc.co/guide/en/kibana/master/get-started.html

- elastic#142780
Doc preview:
https://kibana_145474.docs-preview.app.elstc.co/guide/en/kibana/master/add-controls.html

- elastic#143762
Doc preview:
https://kibana_145474.docs-preview.app.elstc.co/guide/en/kibana/master/add-controls.html

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
(cherry picked from commit 9a26af6)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.6

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Nov 28, 2022
@kibanamachine @KOTungseth
[8.6] [DOCS] Adds the 8.6 Presentation docs (#145474) (#146430)
dad6bff 
# Backport

This will backport the following commits from `main` to `8.6`:
- [[DOCS] Adds the 8.6 Presentation docs
(#145474)](#145474)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Kaarina
Tungseth","email":"kaarina.tungseth@elastic.co"},"sourceCommit":{"committedDate":"2022-11-28T16:20:38Z","message":"[DOCS]
Adds the 8.6 Presentation docs (#145474)\n\n## Summary\r\n\r\nAdds the
docs for the following:\r\n\r\n- #141824\r\nDoc
preview:\r\nhttps://kibana_145474.docs-preview.app.elstc.co/guide/en/kibana/master/get-started.html\r\n\r\n-
#142780\r\nDoc
preview:\r\nhttps://kibana_145474.docs-preview.app.elstc.co/guide/en/kibana/master/add-controls.html\r\n\r\n-
#143762\r\nDoc
preview:\r\nhttps://kibana_145474.docs-preview.app.elstc.co/guide/en/kibana/master/add-controls.html\r\n\r\nCo-authored-by:
gchaps
<33642766+gchaps@users.noreply.github.com>","sha":"9a26af6facafa9519ac624901805a1a65c8abb09","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Docs","Team:Presentation","release_note:skip","v8.6.0","v8.7.0"],"number":145474,"url":"https://github.com/elastic/kibana/pull/145474","mergeCommit":{"message":"[DOCS]
Adds the 8.6 Presentation docs (#145474)\n\n## Summary\r\n\r\nAdds the
docs for the following:\r\n\r\n- #141824\r\nDoc
preview:\r\nhttps://kibana_145474.docs-preview.app.elstc.co/guide/en/kibana/master/get-started.html\r\n\r\n-
#142780\r\nDoc
preview:\r\nhttps://kibana_145474.docs-preview.app.elstc.co/guide/en/kibana/master/add-controls.html\r\n\r\n-
#143762\r\nDoc
preview:\r\nhttps://kibana_145474.docs-preview.app.elstc.co/guide/en/kibana/master/add-controls.html\r\n\r\nCo-authored-by:
gchaps
<33642766+gchaps@users.noreply.github.com>","sha":"9a26af6facafa9519ac624901805a1a65c8abb09"}},"sourceBranch":"main","suggestedTargetBranches":["8.6"],"targetPullRequestStates":[{"branch":"8.6","label":"v8.6.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/145474","number":145474,"mergeCommit":{"message":"[DOCS]
Adds the 8.6 Presentation docs (#145474)\n\n## Summary\r\n\r\nAdds the
docs for the following:\r\n\r\n- #141824\r\nDoc
preview:\r\nhttps://kibana_145474.docs-preview.app.elstc.co/guide/en/kibana/master/get-started.html\r\n\r\n-
#142780\r\nDoc
preview:\r\nhttps://kibana_145474.docs-preview.app.elstc.co/guide/en/kibana/master/add-controls.html\r\n\r\n-
#143762\r\nDoc
preview:\r\nhttps://kibana_145474.docs-preview.app.elstc.co/guide/en/kibana/master/add-controls.html\r\n\r\nCo-authored-by:
gchaps
<33642766+gchaps@users.noreply.github.com>","sha":"9a26af6facafa9519ac624901805a1a65c8abb09"}}]}]
BACKPORT-->

Co-authored-by: Kaarina Tungseth <kaarina.tungseth@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Heenawter Heenawter Heenawter left review comments

@gchaps gchaps gchaps approved these changes

@nreese nreese Awaiting requested review from nreese

@ThomThomson ThomThomson Awaiting requested review from ThomThomson

Assignees

@KOTungseth KOTungseth

Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Docs Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v8.6.0 v8.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@KOTungseth @elasticmachine @kibanamachine @Heenawter @gchaps