Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RAM] Fix broken action type filter in rules list #145691

Merged
merged 7 commits into from
Nov 21, 2022
Merged

[RAM] Fix broken action type filter in rules list #145691

merged 7 commits into from
Nov 21, 2022

Conversation

jcger
Copy link
Contributor

@jcger jcger commented Nov 18, 2022 •
edited by kibanamachine
Loading

Summary

Closes #145636

Screen.Recording.2022-11-18.at.09.09.48.mov

Checklist

@jcger jcger changed the title set the right prop as filter value [RAM] Fix broken action type filter in rules list Nov 18, 2022
@jcger jcger added backport v8.6.0 release_note:fix Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) labels Nov 18, 2022
@jcger jcger marked this pull request as ready for review November 18, 2022 09:10
@jcger jcger requested a review from a team as a code owner November 18, 2022 09:10
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@XavierM XavierM added the v8.7.0 label Nov 18, 2022
@jcger jcger added the ci:cloud-deploy Create or update a Cloud deployment label Nov 18, 2022
@jcger jcger added ci:cloud-redeploy Always create a new Cloud deployment and removed ci:cloud-deploy Create or update a Cloud deployment labels Nov 18, 2022
@jcger jcger added ci:cloud-deploy Create or update a Cloud deployment and removed ci:cloud-redeploy Always create a new Cloud deployment labels Nov 18, 2022
@jcger jcger enabled auto-merge (squash) November 21, 2022 07:22
@kibana-ci
Copy link
Collaborator

kibana-ci commented Nov 21, 2022 •
edited
Loading

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

ESLint disabled in files

id before after diff
osquery 1 2 +1

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
fleet 59 65 +6
osquery 109 115 +6
securitySolution 442 448 +6
total +20

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
fleet 67 73 +6
osquery 110 117 +7
securitySolution 519 525 +6
total +21

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jcger jcger merged commit 87c64dd into elastic:main Nov 21, 2022
@kibanamachine kibanamachine mentioned this pull request Nov 21, 2022
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 21, 2022
@jcger
[RAM] Fix broken action type filter in rules list (elastic#145691)
627be98 
## Summary

Closes elastic#145636

https://user-images.githubusercontent.com/17549662/202652963-205d1590-5cdf-4b4c-8f8b-e1133e6c274c.mov

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

(cherry picked from commit 87c64dd)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.6

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Nov 21, 2022
@kibanamachine @jcger
[8.6] [RAM] Fix broken action type filter in rules list (#145691) (#1…
310dd41 
…45809)

# Backport

This will backport the following commits from `main` to `8.6`:
- [[RAM] Fix broken action type filter in rules list
(#145691)](#145691)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Julian
Gernun","email":"17549662+jcger@users.noreply.github.com"},"sourceCommit":{"committedDate":"2022-11-21T08:18:34Z","message":"[RAM]
Fix broken action type filter in rules list (#145691)\n\n##
Summary\r\n\r\nCloses
https://github.com/elastic/kibana/issues/145636\r\n\r\n\r\nhttps://user-images.githubusercontent.com/17549662/202652963-205d1590-5cdf-4b4c-8f8b-e1133e6c274c.mov\r\n\r\n###
Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"87c64dd14a6d9c508249a55036ca7c13ee33363b","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["backport","release_note:fix","Team:ResponseOps","ci:cloud-deploy","v8.6.0","v8.7.0"],"number":145691,"url":"https://github.com/elastic/kibana/pull/145691","mergeCommit":{"message":"[RAM]
Fix broken action type filter in rules list (#145691)\n\n##
Summary\r\n\r\nCloses
https://github.com/elastic/kibana/issues/145636\r\n\r\n\r\nhttps://user-images.githubusercontent.com/17549662/202652963-205d1590-5cdf-4b4c-8f8b-e1133e6c274c.mov\r\n\r\n###
Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"87c64dd14a6d9c508249a55036ca7c13ee33363b"}},"sourceBranch":"main","suggestedTargetBranches":["8.6"],"targetPullRequestStates":[{"branch":"8.6","label":"v8.6.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/145691","number":145691,"mergeCommit":{"message":"[RAM]
Fix broken action type filter in rules list (#145691)\n\n##
Summary\r\n\r\nCloses
https://github.com/elastic/kibana/issues/145636\r\n\r\n\r\nhttps://user-images.githubusercontent.com/17549662/202652963-205d1590-5cdf-4b4c-8f8b-e1133e6c274c.mov\r\n\r\n###
Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"87c64dd14a6d9c508249a55036ca7c13ee33363b"}}]}]
BACKPORT-->

Co-authored-by: Julian Gernun <17549662+jcger@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guskovaue guskovaue guskovaue approved these changes

Assignees
No one assigned
Labels
backport ci:cloud-deploy Create or update a Cloud deployment release_note:fix Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.6.0 v8.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rule list view 'Action type' filter is broken
6 participants
@jcger @elasticmachine @kibana-ci @kibanamachine @guskovaue @XavierM