Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enterprise Search] Fix logic for long running and orphaned jobs #145714

Merged
merged 2 commits into from
Nov 22, 2022
Merged

[Enterprise Search] Fix logic for long running and orphaned jobs #145714

merged 2 commits into from
Nov 22, 2022

Conversation

sphilipse
Copy link
Member

@sphilipse sphilipse commented Nov 18, 2022 •
edited
Loading

This fixes the logic for long-running connector sync jobs: they should look at started_at rather than last_seen.
It also fixes the logic for orphaned jobs, which were displaying the opposite of what they should have been displaying.

@sphilipse sphilipse added release_note:skip Skip the PR/issue when compiling release notes Team:EnterpriseSearch v8.6.0 v8.7.0 labels Nov 18, 2022
@sphilipse sphilipse requested a review from a team November 18, 2022 11:45
@sphilipse sphilipse changed the title [Enterprise Search] Fix logic for long running jobs selection [Enterprise Search] Fix logic for long running and orphaned jobs Nov 18, 2022
@sphilipse sphilipse force-pushed the ent-search-fix-long-running-stats branch 2 times, most recently from 0045dff to 1e67574 Compare November 21, 2022 11:04
@sphilipse sphilipse force-pushed the ent-search-fix-long-running-stats branch from 1e67574 to 274f5ee Compare November 21, 2022 11:05
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

ESLint disabled in files

id before after diff
osquery 1 2 +1

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
fleet 59 65 +6
osquery 109 115 +6
securitySolution 442 448 +6
total +20

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
fleet 67 73 +6
osquery 110 117 +7
securitySolution 519 525 +6
total +21

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@sphilipse sphilipse merged commit 2e178f8 into elastic:main Nov 22, 2022
@kibanamachine kibanamachine mentioned this pull request Nov 28, 2022
Merged
@sphilipse sphilipse mentioned this pull request Nov 29, 2022
Merged
@sphilipse
Copy link
Member Author

💚 All backports created successfully

Status Branch Result
✅ 8.6

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

sphilipse added a commit to sphilipse/kibana that referenced this pull request Nov 29, 2022
@sphilipse
[Enterprise Search] Fix logic for long running and orphaned jobs (ela…
fc5d4b5 
…stic#145714)

This fixes the logic for long-running connector sync jobs: they should
look at started_at rather than last_seen.
It also fixes the logic for orphaned jobs, which were displaying the
opposite of what they should have been displaying.

(cherry picked from commit 2e178f8)
sphilipse added a commit that referenced this pull request Nov 29, 2022
@sphilipse
[8.6] [Enterprise Search] Fix logic for long running and orphaned jobs (
218162f 
#145714) (#146514)

# Backport

This will backport the following commits from `main` to `8.6`:
- [[Enterprise Search] Fix logic for long running and orphaned jobs
(#145714)](#145714)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Sander
Philipse","email":"94373878+sphilipse@users.noreply.github.com"},"sourceCommit":{"committedDate":"2022-11-22T13:27:46Z","message":"[Enterprise
Search] Fix logic for long running and orphaned jobs (#145714)\n\nThis
fixes the logic for long-running connector sync jobs: they
should\r\nlook at started_at rather than last_seen.\r\nIt also fixes the
logic for orphaned jobs, which were displaying the\r\nopposite of what
they should have been
displaying.","sha":"2e178f8f450ad6019903af17881c8368806816c8","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:EnterpriseSearch","v8.6.0","v8.7.0"],"number":145714,"url":"https://github.com/elastic/kibana/pull/145714","mergeCommit":{"message":"[Enterprise
Search] Fix logic for long running and orphaned jobs (#145714)\n\nThis
fixes the logic for long-running connector sync jobs: they
should\r\nlook at started_at rather than last_seen.\r\nIt also fixes the
logic for orphaned jobs, which were displaying the\r\nopposite of what
they should have been
displaying.","sha":"2e178f8f450ad6019903af17881c8368806816c8"}},"sourceBranch":"main","suggestedTargetBranches":["8.6"],"targetPullRequestStates":[{"branch":"8.6","label":"v8.6.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/145714","number":145714,"mergeCommit":{"message":"[Enterprise
Search] Fix logic for long running and orphaned jobs (#145714)\n\nThis
fixes the logic for long-running connector sync jobs: they
should\r\nlook at started_at rather than last_seen.\r\nIt also fixes the
logic for orphaned jobs, which were displaying the\r\nopposite of what
they should have been
displaying.","sha":"2e178f8f450ad6019903af17881c8368806816c8"}}]}]
BACKPORT-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@byronhulcher byronhulcher byronhulcher approved these changes

Assignees
No one assigned
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:EnterpriseSearch v8.6.0 v8.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sphilipse @kibana-ci @byronhulcher