Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RAM] need to return the async id to avoid new request #145731

Merged
merged 3 commits into from
Nov 21, 2022
Merged

[RAM] need to return the async id to avoid new request #145731

merged 3 commits into from
Nov 21, 2022

Conversation

XavierM
Copy link
Contributor

@XavierM XavierM commented Nov 18, 2022 •
edited by kibanamachine
Loading

Summary

Fix: #129219 & #144619

Checklist

@XavierM XavierM added bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.6.0 v8.7.0 labels Nov 18, 2022
@XavierM XavierM requested review from a team as code owners November 18, 2022 13:55
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@XavierM XavierM added the ci:cloud-deploy Create or update a Cloud deployment label Nov 18, 2022
@XavierM XavierM changed the title need to return the async id to avoid new request [RAM] need to return the async id to avoid new request Nov 18, 2022
@XavierM
Copy link
Contributor Author

XavierM commented Nov 18, 2022

To check the flakiness -> https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/1570

@XavierM
Copy link
Contributor Author

XavierM commented Nov 18, 2022

@elasticmachine merge upstream

@XavierM XavierM added the ci:cloud-redeploy Always create a new Cloud deployment label Nov 18, 2022
@XavierM
Copy link
Contributor Author

XavierM commented Nov 21, 2022

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

kibana-ci commented Nov 21, 2022 •
edited
Loading

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

ESLint disabled in files

id before after diff
osquery 1 2 +1

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
fleet 59 65 +6
osquery 109 115 +6
securitySolution 443 449 +6
total +20

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
fleet 67 73 +6
osquery 110 117 +7
securitySolution 520 526 +6
total +21

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

JiaweiWu
JiaweiWu approved these changes Nov 21, 2022
View reviewed changes
Copy link
Contributor

@JiaweiWu JiaweiWu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@XavierM XavierM merged commit 58a3747 into elastic:main Nov 21, 2022
@kibanamachine kibanamachine mentioned this pull request Nov 21, 2022
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 21, 2022
@XavierM
[RAM] need to return the async id to avoid new request (elastic#145731)
0fee068 
## Summary

Fix: elastic#129219 &
elastic#144619

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 58a3747)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.6

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Nov 21, 2022
@kibanamachine @XavierM
[8.6] [RAM] need to return the async id to avoid new request (#145731) (
33fe536 
#145930)

# Backport

This will backport the following commits from `main` to `8.6`:
- [[RAM] need to return the async id to avoid new request
(#145731)](#145731)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Xavier
Mouligneau","email":"xavier.mouligneau@elastic.co"},"sourceCommit":{"committedDate":"2022-11-21T20:02:06Z","message":"[RAM]
need to return the async id to avoid new request (#145731)\n\n##
Summary\r\n\r\nFix: #129219
&\r\nhttps://github.com//issues/144619\r\n\r\n\r\n###
Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios\r\n\r\nCo-authored-by: Kibana Machine
<42973632+kibanamachine@users.noreply.github.com>","sha":"58a374799b41108929527a239bae68b3ac7cc346","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","impact:high","Team:ResponseOps","ci:cloud-deploy","ci:cloud-redeploy","v8.6.0","v8.7.0"],"number":145731,"url":"https://github.com/elastic/kibana/pull/145731","mergeCommit":{"message":"[RAM]
need to return the async id to avoid new request (#145731)\n\n##
Summary\r\n\r\nFix: #129219
&\r\nhttps://github.com//issues/144619\r\n\r\n\r\n###
Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios\r\n\r\nCo-authored-by: Kibana Machine
<42973632+kibanamachine@users.noreply.github.com>","sha":"58a374799b41108929527a239bae68b3ac7cc346"}},"sourceBranch":"main","suggestedTargetBranches":["8.6"],"targetPullRequestStates":[{"branch":"8.6","label":"v8.6.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/145731","number":145731,"mergeCommit":{"message":"[RAM]
need to return the async id to avoid new request (#145731)\n\n##
Summary\r\n\r\nFix: #129219
&\r\nhttps://github.com//issues/144619\r\n\r\n\r\n###
Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios\r\n\r\nCo-authored-by: Kibana Machine
<42973632+kibanamachine@users.noreply.github.com>","sha":"58a374799b41108929527a239bae68b3ac7cc346"}}]}]
BACKPORT-->

Co-authored-by: Xavier Mouligneau <xavier.mouligneau@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JiaweiWu JiaweiWu JiaweiWu approved these changes

Assignees
No one assigned
Labels
bug Fixes for quality problems that affect the customer experience ci:cloud-deploy Create or update a Cloud deployment ci:cloud-redeploy Always create a new Cloud deployment impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.6.0 v8.7.0
Projects
None yet
Milestone
No milestone
5 participants
@XavierM @elasticmachine @kibana-ci @kibanamachine @JiaweiWu