Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DataViews] Fix form validation UX when the same data view name already exists #146126

Merged
merged 4 commits into from
Nov 25, 2022
Merged

[DataViews] Fix form validation UX when the same data view name already exists #146126

merged 4 commits into from
Nov 25, 2022

Conversation

jughosta
Copy link
Contributor

Closes #138958

Summary

This PR fixes form UX when the same data view name already exists.

Nov-23-2022 11-35-34

@jughosta jughosta added release_note:fix Feature:Data Views Data Views code and UI - index patterns before 8.0 backport:skip This commit does not require backporting Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. v8.7.0 labels Nov 23, 2022
@jughosta jughosta self-assigned this Nov 23, 2022
@jughosta jughosta marked this pull request as ready for review November 23, 2022 12:31
@jughosta jughosta requested a review from a team as a code owner November 23, 2022 12:31
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

davismcphee
davismcphee reviewed Nov 23, 2022
View reviewed changes
Copy link
Contributor

@davismcphee davismcphee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes LGTM, but I noticed the error handling still doesn't work when the data view name is auto generated from the pattern. Would you like to fix that as part of this PR, or would you prefer I create a separate issue for the problem?
create_data_view

@jughosta
Copy link
Contributor Author

@davismcphee I don't have a solution for the problem you mentioned. Let's create a separate issue.

@davismcphee davismcphee mentioned this pull request Nov 25, 2022
Closed
davismcphee
davismcphee approved these changes Nov 25, 2022
View reviewed changes
Copy link
Contributor

@davismcphee davismcphee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@davismcphee I don't have a solution for the problem you mentioned. Let's create a separate issue.

Sounds good, created: #146338. And in that case, this LGTM.

@jughosta jughosta enabled auto-merge (squash) November 25, 2022 12:41
@jughosta jughosta merged commit 0e327d3 into elastic:main Nov 25, 2022
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
dataViewEditor 34.7KB 34.8KB +56.0B
Unknown metric groups

ESLint disabled in files

id before after diff
osquery 1 2 +1

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
fleet 59 65 +6
osquery 109 115 +6
securitySolution 443 449 +6
total +20

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
fleet 68 74 +6
osquery 110 117 +7
securitySolution 520 526 +6
total +21

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jughosta

@jughosta jughosta deleted the 138958-fix-form-state branch November 28, 2022 08:08
jloleysens added a commit to jloleysens/kibana that referenced this pull request Nov 28, 2022
@jloleysens
Merge branch 'main' into files-move-components-to-packages-upload-file
9133d24 
* main: (30 commits)
  [Cloud Posture] test latest findings table sort (elastic#144668)
  [api-docs] 2022-11-28 Daily api_docs build (elastic#146359)
  [api-docs] 2022-11-27 Daily api_docs build (elastic#146353)
  [api-docs] 2022-11-26 Daily api_docs build (elastic#146350)
  [DataViews] Fix form validation UX when the same data view name already exists (elastic#146126)
  [Discover] Prevent agg based visualizations of Discover saved objects with adhoc data views (elastic#145583)
  [Health Gateway] Update response aggregation (elastic#145761)
  [api-docs] 2022-11-25 Daily api_docs build (elastic#146341)
  [Metric threshold rule] Adds new context variable for group by keys (elastic#145654)
  [Controls] [Portable Dashboards] Add control group renderer example plugin (elastic#146189)
  Refactor Observability Overview Page (elastic#146182)
  Send complete test data to xMatters, so it can create an alert (elastic#145431)
  [Dashboard] [Controls] Allow options list suggestions to be sorted (elastic#144867)
  Add open API specification for list connector types (elastic#145951)
  skip flaky suite (elastic#146086)
  [ML] Removing duplicate tooltip text (elastic#146308)
  Refactor Rules Page (elastic#146193)
  [DOCS] Alert limit for cases (elastic#145950)
  Extend session index fields mapping with a session creation timestamp. (elastic#145997)
  [Files] Move <Image /> component to `@kbn/shared-ux` package (elastic#145995)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davismcphee davismcphee davismcphee approved these changes

Assignees

@jughosta jughosta

Labels
backport:skip This commit does not require backporting Feature:Data Views Data Views code and UI - index patterns before 8.0 release_note:fix Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. v8.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Save data view button should be disabled when user inputs duplicate data view name
4 participants
@jughosta @elasticmachine @kibana-ci @davismcphee