Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security solution] add type and value to index patterns passed to unified search #146245

Closed
wants to merge 8 commits into from

Conversation

stephmilovic
Copy link
Contributor

@stephmilovic stephmilovic commented Nov 23, 2022

Summary

I noticed this error being thrown in the console across the app for the past several weeks
Screen Shot 2022-11-23 at 4 08 11 PM

Unified search is now using properties on passed data views of type: 'id' | 'title'; value: string where the value is the data view property corresponding with the type. We are missing those properties in security solution. This PR adds them in security_solution and timelines plugins.

@stephmilovic stephmilovic added release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Security Solution Platform Security Solution Platform Team Team:Threat Hunting:Investigations Security Solution Investigations Team v8.6.0 v8.7.0 labels Nov 23, 2022
@kibana-ci
Copy link
Collaborator

kibana-ci commented Nov 23, 2022

💔 Build Failed

Failed CI Steps

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
securitySolution 3313 3314 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 9.6MB 9.6MB +875.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@stephmilovic
Copy link
Contributor Author

ok no need for this after all, closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Security Solution Platform Security Solution Platform Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Investigations Security Solution Investigations Team v8.6.0 v8.7.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants