-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enterprise Search] Fix support for cron scheduling for Elastic Crawler Indices #146357
[Enterprise Search] Fix support for cron scheduling for Elastic Crawler Indices #146357
Conversation
setUseConnectorSchedule: actions.saveChanges, | ||
toggleCrawlAutomatically: actions.saveChanges, | ||
submitConnectorSchedule: async ({ scheduling }) => { | ||
try { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note: this won't work as makeUpdateConnectorSchedulingRequest will always succeed. Need to listen for the error action instead.
@elasticmachine merge upstream |
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Async chunks
Unknown metric groupsESLint disabled in files
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
…er Indices (elastic#146357) (cherry picked from commit 5b79dbe)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
… Crawler Indices (#146357) (#146463) # Backport This will backport the following commits from `main` to `8.6`: - [[Enterprise Search] Fix support for cron scheduling for Elastic Crawler Indices (#146357)](#146357) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Byron Hulcher","email":"byronhulcher@gmail.com"},"sourceCommit":{"committedDate":"2022-11-28T19:13:08Z","message":"[Enterprise Search] Fix support for cron scheduling for Elastic Crawler Indices (#146357)","sha":"5b79dbea96c9e4694cec2e47d87b1bcbea6740b5","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:EnterpriseSearch","backport:prev-minor","v8.6.0","v8.7.0"],"number":146357,"url":"https://github.com/elastic/kibana/pull/146357","mergeCommit":{"message":"[Enterprise Search] Fix support for cron scheduling for Elastic Crawler Indices (#146357)","sha":"5b79dbea96c9e4694cec2e47d87b1bcbea6740b5"}},"sourceBranch":"main","suggestedTargetBranches":["8.6"],"targetPullRequestStates":[{"branch":"8.6","label":"v8.6.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/146357","number":146357,"mergeCommit":{"message":"[Enterprise Search] Fix support for cron scheduling for Elastic Crawler Indices (#146357)","sha":"5b79dbea96c9e4694cec2e47d87b1bcbea6740b5"}}]}] BACKPORT--> Co-authored-by: Byron Hulcher <byronhulcher@gmail.com>
Summary
enabled: true
is set consistently with theuse_connecter_schedule
prop stored in Crawler2's connector scheduleChecklist